Invalidate array type info when using array_{push,pop,shift,unshift}#101
Merged
ondrejmirtes merged 1 commit intophpstan:masterfrom Jan 14, 2020
Merged
Invalidate array type info when using array_{push,pop,shift,unshift}#101ondrejmirtes merged 1 commit intophpstan:masterfrom
ondrejmirtes merged 1 commit intophpstan:masterfrom
Conversation
Member
|
Something like that is already done here: phpstan-src/src/Analyser/NodeScopeResolver.php Lines 2129 to 2134 in 8376548 Thank you! PR makes perfect sense. Maybe we could call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#2750
Seems to me like it's probably worth something more generic like - if the method has side effects and argument is passed by reference invalidate the argument.