Add ./phpstan alias to ./phpstan.phar#4390
Merged
ondrejmirtes merged 4 commits intophpstan:masterfrom Jan 19, 2021
mvorisek:phpstan_entry
Merged
Add ./phpstan alias to ./phpstan.phar#4390ondrejmirtes merged 4 commits intophpstan:masterfrom mvorisek:phpstan_entry
ondrejmirtes merged 4 commits intophpstan:masterfrom
mvorisek:phpstan_entry
Conversation
Member
|
I don't understand this PR. If it's a symlink then it won't work. It used to be a symlink a long time ago but we abandoned that approach. |
Contributor
Author
|
GH displays it weirdly, check the 2nd commit diff |
Member
|
Alright, looks promising, but check out the build failures here. |
Member
|
@mvorisek I tried removing that patcher, please rebase this PR so we can see if the build passes. |
Member
|
It's obvious why it doesn't work - when running PHPStan throug the |
Contributor
Author
|
It's obvious, yes, but how to fix it? |
Member
|
If I knew how, I'd already done it. |
Member
|
Wow, looks like you really figured it out! |
This was referenced Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2/2 PR for #4389