Skip to content

Support all atomic types as nullable types#129

Merged
ondrejmirtes merged 2 commits intophpstan:1.6.xfrom
rvanvelzen:nullable-atomic
Jun 8, 2022
Merged

Support all atomic types as nullable types#129
ondrejmirtes merged 2 commits intophpstan:1.6.xfrom
rvanvelzen:nullable-atomic

Conversation

@rvanvelzen
Copy link
Copy Markdown
Contributor

Fixes #124

@ondrejmirtes
Copy link
Copy Markdown
Member

Perfect! I'm eager to merge this too :)

@rvanvelzen rvanvelzen marked this pull request as ready for review June 8, 2022 19:27
@ondrejmirtes ondrejmirtes merged commit 1e355a3 into phpstan:1.6.x Jun 8, 2022
@ondrejmirtes
Copy link
Copy Markdown
Member

Thank you!

@ondrejmirtes
Copy link
Copy Markdown
Member

FYI I'm gonna try phpdoc-parser in phpstan-src again after this suggestion phpstan/phpstan-src#1406 (comment) - I think it's really necessary to make it optional and non-default because the new behaviour is much stricter and will make a lot of projects fail, so it's a good fit for bleedingEdge (and will allow us to release it in a minor phpdoc-parser version).

@ondrejmirtes
Copy link
Copy Markdown
Member

But I understand it's not trivial. Ideally I'd like to see all current data providers to be tested with both true / false and only those that differ to be tested in a different test case method probably.

@rvanvelzen
Copy link
Copy Markdown
Contributor Author

rvanvelzen commented Jun 8, 2022

I'll hopefully get to it tomorrow :)

@rvanvelzen rvanvelzen deleted the nullable-atomic branch June 9, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type parsing when combinding nullable and consts-types

2 participants