Ensure isValid() will not last more than timeout seconds#1557
Ensure isValid() will not last more than timeout seconds#1557davecramer merged 5 commits intopgjdbc:masterfrom arobert-delfingen:issue/1556
Conversation
even if the underlying socket is broken (issue #1556)
|
❌ Build pgjdbc 1.0.421 failed (commit 163c5734e4 by @arobert-delfingen) |
|
Makes sense |
|
@arobert-delfingen can you rebase and push another commit as the .travis.yml file was broken, thanks |
|
❌ Build pgjdbc 1.0.426 failed (commit 97ee10d8b3 by @arobert-delfingen) |
|
❌ Build pgjdbc 1.0.427 failed (commit f9267d2bff by @arobert-delfingen) |
|
@arobert-delfingen so this is now failing most all tests, except for checkstyle ... |
|
✅ Build pgjdbc 1.0.431 completed (commit ee98bc6506 by @arobert-delfingen) |
|
Now all tests succeed, but theoritically I should :
|
Codecov Report
@@ Coverage Diff @@
## master #1557 +/- ##
============================================
- Coverage 68.92% 68.88% -0.04%
Complexity 3971 3971
============================================
Files 179 179
Lines 16545 16569 +24
Branches 2695 2695
============================================
+ Hits 11403 11414 +11
- Misses 3890 3902 +12
- Partials 1252 1253 +1 |
|
@arobert-delfingen yes, to all of the above. Thanks! |
|
❌ Build pgjdbc 1.0.433 failed (commit f24a7f85d6 by @arobert-delfingen) |
|
Any idea why when writen like this it breaks test ? where is my mistake ? |
|
I don't worry too much about Appveyor failures. If it passes Travis I'm good. |
|
❌ Build pgjdbc 1.0.433 failed (commit f24a7f85d6 by @arobert-delfingen) |
PostgreSQL JDBC driver has a bug where the isValid() call on a connection does not respect timeouts. This causes our connection pool to not detect a dead connection, which will eventually exhaust our connection pool entirely. See pgjdbc/pgjdbc#1557
PostgreSQL JDBC driver has a bug where the isValid() call on a connection does not respect timeouts. This causes our connection pool to not detect a dead connection, which will eventually exhaust our connection pool entirely. See pgjdbc/pgjdbc#1557
This PR is to just to give an idea how to fix issue #1556, but never tested