Disable speedups for GraalPython#278
Merged
davidism merged 1 commit intopallets:mainfrom Feb 16, 2022
Merged
Conversation
Member
|
I've considered changing this to "only compile when cpython", but I'm really not sure what proportion of implementations can or can't use speedups at this point. |
Contributor
Author
|
I don't know which other imlementations support the speedups, but I think in general "only compile when CPython" sounds better to me. Because if you don't use the speedups on an interpreter that could support them, the result is just a small slowdown. OTOH if you use the speedups on an interpreter that doesn't support them, it can crash. So flipping the condition to be CPython-only sounds safer. Do you want me to do it? |
Member
|
I'm going to merge this as-is for now. I want to understand what implementations are out there before I commit to a bigger change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable speedups module for GraalPython as it doesn't work and wouldn't provide any speedups anyway. CC @timfel
Fixes #277
Checklist:
GraalPython doesn't yet work out of the box with tox. Since there is no testenv for Jython either, I hope that's fine.
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.