Tests: Adapt expected traceback regexes for Python 3.11.0a1#1527
Merged
davidism merged 1 commit intopallets:3.0.xfrom Nov 5, 2021
Merged
Tests: Adapt expected traceback regexes for Python 3.11.0a1#1527davidism merged 1 commit intopallets:3.0.xfrom
davidism merged 1 commit intopallets:3.0.xfrom
Conversation
36dc0bc to
7cb34db
Compare
ThiefMaster
reviewed
Nov 4, 2021
7cb34db to
ed9f08f
Compare
ed9f08f to
c2031f6
Compare
Member
|
Can you rebase this to 3.0.x branch? |
Contributor
Author
In a separate PR or here? |
Member
|
Here, change the target of the PR by clicking "edit" next to the title, then do: |
c2031f6 to
d5a436c
Compare
Contributor
Author
|
It made all the previously succeeded CI jobs fail with |
Member
|
Looks like some problem on GitHub's side. I restarted the CI run and it's fine now. But I think we need to update our CI config to test against 3.10 and 3.11 as well... |
Contributor
Author
Pushed to see if it works. |
b691e64 to
ad66b79
Compare
Contributor
Author
|
It works 🎉 |
ThiefMaster
reviewed
Nov 5, 2021
Merged
Fixes pallets#1526 Before: File ".../broken.html", line 2, in <module> {{ fail() }} File ".../test_debug.py", line 32, in <lambda> tmpl.render(fail=lambda: 1 / 0) ZeroDivisionError: division by zero After: File ".../broken.html", line 2, in <module> {{ fail() }} ^^^^^^^^^^^^ File ".../test_debug.py", line 32, in <lambda> tmpl.render(fail=lambda: 1 / 0) ~~^~~ ZeroDivisionError: division by zero
ad66b79 to
7577566
Compare
Contributor
Author
|
@davidism Thanks for merging and adapting the CI as well 🍷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1526
Before:
After:
Checklist:
Add tests that demonstrate the correct behavior of the changethis is in testsAdd or update relevant docs, in the docs folder and in codethis is in tests and too early to declare Python 3.11 support in docsAdd an entry inadded but then removed per reviewCHANGES.rstsummarizing the change and linking to the issueAddthis is in tests.. versionchanged::entries in any relevant code docspre-commithooks and fix any issues.pytestandtox, no tests failed.