move extractors and generic schema utilities out of handler.rs#554
Merged
Conversation
fb1aa57 to
9df46f7
Compare
Collaborator
Author
|
Sorry for the force push and general noise. |
9 tasks
ahl
approved these changes
Jan 11, 2023
ahl
left a comment
Collaborator
There was a problem hiding this comment.
I really like this reorganization. I said "oooh" aloud when I saw that extractor was its own mod--like it a lot.
api_description.rs has a bunch of j2oas_ prefixed functions; would those make sense to move into schema_util.rs? No or Not now are fine answers.
Collaborator
Author
|
Thanks for the review.
That looks like a good idea. I will do it in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt like handler.rs was getting a bit big and full of unrelated stuff. Here I'm separating the extractors into a submodule with the eventual intent on putting different ones into different files within
extractors. This involved moving some functions used by both handler.rs and the new extractor module into schema_util.rs (analogous to http_util.rs).I believe nothing has changed in this PR except for moving code from one file to another and adjusting imports / "mod" statements.
This depends on #553 -- will update the base branch once that one lands and I'll keep this in "draft" for the meantime.