Add system-wide per-process file descriptors limits#2218
Merged
Conversation
6f5e69d to
ccc2da2
Compare
ccc2da2 to
68935ac
Compare
Contributor
|
|
dbwiddis
requested changes
Oct 23, 2022
dbwiddis
left a comment
Member
There was a problem hiding this comment.
Great start, and thanks for your contribution!
Some improvements suggested inline.
dbwiddis
approved these changes
Oct 23, 2022
Member
|
I went ahead and approved this and will merge when CI finishes, as I know you're working on "part 2". I think the AIX still needs to somehow check the per-user limit, and it requires admin privileges (so I have no way to even test) so I'm ok leaving it is as is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #2215