Skip to content

Add system-wide per-process file descriptors limits#2218

Merged
dbwiddis merged 11 commits into
oshi:masterfrom
gitseti:process-file-limits
Oct 23, 2022
Merged

Add system-wide per-process file descriptors limits#2218
dbwiddis merged 11 commits into
oshi:masterfrom
gitseti:process-file-limits

Conversation

@gitseti

@gitseti gitseti commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Context: #2215

@gitseti gitseti force-pushed the process-file-limits branch 2 times, most recently from 6f5e69d to ccc2da2 Compare October 23, 2022 16:12
@gitseti gitseti force-pushed the process-file-limits branch from ccc2da2 to 68935ac Compare October 23, 2022 16:13
@sonatype-lift

sonatype-lift Bot commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

⚠️ 26 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

Comment thread oshi-core/src/main/java/oshi/software/os/mac/MacFileSystem.java

@dbwiddis dbwiddis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, and thanks for your contribution!

Some improvements suggested inline.

Comment thread oshi-core/src/main/java/oshi/software/os/unix/aix/AixFileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/software/os/unix/solaris/SolarisFileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/software/os/unix/solaris/SolarisFileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/software/os/unix/solaris/SolarisFileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/util/platform/linux/ProcPath.java Outdated
Comment thread CHANGELOG.md
Comment thread oshi-core/src/main/java/oshi/software/os/FileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/software/os/FileSystem.java Outdated
Comment thread oshi-core/src/main/java/oshi/software/os/linux/LinuxFileSystem.java Outdated
@gitseti gitseti requested a review from dbwiddis October 23, 2022 17:51
@dbwiddis

Copy link
Copy Markdown
Member

I went ahead and approved this and will merge when CI finishes, as I know you're working on "part 2". I think the AIX still needs to somehow check the per-user limit, and it requires admin privileges (so I have no way to even test) so I'm ok leaving it is as is for now.

@dbwiddis dbwiddis merged commit 97282d0 into oshi:master Oct 23, 2022
@gitseti gitseti deleted the process-file-limits branch October 24, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants