Add Processor Cache Information by dbwiddis · Pull Request #2198 · oshi/oshi

dbwiddis · 2022-09-28T01:17:05Z

sonatype-lift · 2022-09-28T01:22:52Z

⚠️ 25 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift · 2022-10-02T04:36:12Z

-    private static Triplet<List<LogicalProcessor>, Map<Integer, Integer>, Map<Integer, String>> readTopologyFromUdev() {
+    private static Quartet<List<LogicalProcessor>, List<ProcessorCache>, Map<Integer, Integer>, Map<Integer, String>> readTopologyFromUdev() {
        List<LogicalProcessor> logProcs = new ArrayList<>();
+        List<Pair<Triplet<List<Integer>, Integer, Type>, Triplet<Integer, Integer, Long>>> caches = new ArrayList<>();


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

List<Pair<Triplet<List<Integer>, Integer, Type>, Triplet<Integer, Integer, Long>>> caches = new ArrayList<>();

List<Pair<Triplet<List<Integer>, Integer, ProcessorCache.Type>, Triplet<Integer, Integer, Long>>> caches = new ArrayList<>();

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-02T17:35:10Z

+        List<ProcessorCache> caches = new ArrayList<>();
+        int cacheSizeL2 = ParseUtil.parseIntOrDefault(ExecutingCommand.getAnswerAt("lsattr -l L2cache0 -E -O", 2), 0);
+        for (int i = 0; i < physProcs; i++) {
+            caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, Type.UNIFIED));


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, Type.UNIFIED));

caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, ProcessorCache.Type.UNIFIED));

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-02T17:35:11Z

        }
+        int lpPerPp = lcpus / physProcs;
+        // Get L2 caches, one per physical processor
+        List<ProcessorCache> caches = new ArrayList<>();


ModifiedButNotUsed: A collection or proto builder was created, but its values were never accessed.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

lgtm-com · 2022-10-02T17:39:30Z

This pull request introduces 1 alert when merging d0b04e8 into 9e1bf98 - view on LGTM.com

new alerts:

1 for Container contents are never accessed

sonatype-lift · 2022-10-02T23:17:56Z

+        int cacheSizeL2 = ParseUtil.parseIntOrDefault(ExecutingCommand.getAnswerAt("lsattr -l L2cache0 -E -O", 2), 0);
+        if (cacheSizeL2 > 0) {
+            for (int i = 0; i < physProcs; i++) {
+                caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, Type.UNIFIED));


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, Type.UNIFIED));

caches.add(new ProcessorCache(i, 2, 0, 64, cacheSizeL2, ProcessorCache.Type.UNIFIED));

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T03:27:42Z

+                }
+                break;
+            case 1:
+                if (cache.getType() == Type.DATA && level1d == null) {


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

if (cache.getType() == Type.DATA && level1d == null) {

if (cache.getType() == ProcessorCache.Type.DATA && level1d == null) {

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T03:27:44Z

+        int powerVersion = ParseUtil.getFirstIntValue(ExecutingCommand.getFirstAnswer("uname -n"));
+        switch (powerVersion) {
+        case 7:
+            caches.add(new ProcessorCache(3, 8, 128, (2 * 32) << 20, Type.UNIFIED));


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

caches.add(new ProcessorCache(3, 8, 128, (2 * 32) << 20, Type.UNIFIED));

caches.add(new ProcessorCache(3, 8, 128, (2 * 32) << 20, ProcessorCache.Type.UNIFIED));

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T03:27:45Z

+        try (Stream<Path> path = Files.list(Paths.get(cachePath))) {
+            path.filter(p -> p.toString().startsWith(indexPrefix)).forEach(c -> {
+                int level = FileUtil.getIntFromFile(c + "/level"); // 1
+                Type type = parseCacheType(FileUtil.getStringFromFile(c + "/type")); // Data


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

Type type = parseCacheType(FileUtil.getStringFromFile(c + "/type")); // Data

ProcessorCache.Type type = parseCacheType(FileUtil.getStringFromFile(c + "/type"));

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T03:27:49Z

        Map<Integer, String> processorIdMap = new HashMap<>();
-        WmiResult<ProcessorIdProperty> processorId = Win32Processor.queryProcessorId();
-        // One entry for each package/socket
+        WmiResult<ProcessorIdProperty> processorId = Win32Processor.queryProcessorId();// One entry for each


INTERFACE_NOT_THREAD_SAFE: Unprotected call to method Ole32.CoInitializeEx(...) of un-annotated interface com.sun.jna.platform.win32.Ole32. Consider annotating the interface with @ThreadSafe or adding a lock.
Reporting because the current class is annotated @ThreadSafe.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T21:57:48Z

+            switch (split[split.length - 1]) {
+            case "I-cache":
+                return new ProcessorCache(1, ParseUtil.getFirstIntValue(split[2]), ParseUtil.getFirstIntValue(split[1]),
+                        ParseUtil.parseDecimalMemorySizeToBinary(split[0]), Type.INSTRUCTION);


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

ParseUtil.parseDecimalMemorySizeToBinary(split[0]), Type.INSTRUCTION);

ParseUtil.parseDecimalMemorySizeToBinary(split[0]), ProcessorCache.Type.INSTRUCTION);

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T21:57:51Z

+    }
+
+    private ProcessorCache parseCacheStr(String cacheStr) {
+        String[] split = ParseUtil.whitespaces.split(cacheStr);


StringSplitter: String.split(String) has surprising behavior

Suggested change

String[] split = ParseUtil.whitespaces.split(cacheStr);

List<String> split = Splitter.on(ParseUtil.whitespaces).splitToList(cacheStr);

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-03T21:57:53Z

+            } else {
+                Matcher n = q.matcher(s);
+                if (n.matches()) {
+                    for (String cacheStr : n.group(1).split(",")) {


StringSplitter: String.split(String) has surprising behavior

Suggested change

for (String cacheStr : n.group(1).split(",")) {

for (String cacheStr : Splitter.on(',').split(n.group(1))) {

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

lgtm-com · 2022-10-04T02:23:58Z

This pull request introduces 1 alert when merging 853a697 into 4a46741 - view on LGTM.com

new alerts:

1 for Array index out of bounds

sonatype-lift · 2022-10-04T03:32:01Z

+        for (String checkLine : ExecutingCommand.runNative("lscpu")) {
+            if (checkLine.contains("L1d cache:")) {
+                caches.add(new ProcessorCache(1, 0, 0,
+                        ParseUtil.parseDecimalMemorySizeToBinary(checkLine.split(":")[1].trim()), Type.DATA));


BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: ProcessorCache.

Suggested change

ParseUtil.parseDecimalMemorySizeToBinary(checkLine.split(":")[1].trim()), Type.DATA));

ParseUtil.parseDecimalMemorySizeToBinary(checkLine.split(":")[1].trim()), ProcessorCache.Type.DATA));

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

lgtm-com · 2022-10-04T03:38:10Z

This pull request introduces 1 alert when merging c9e272a into 4a46741 - view on LGTM.com

new alerts:

1 for Array index out of bounds

Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>

mprins · 2022-10-29T13:20:32Z

        if (lcpus < 1) {
            lcpus = 1;
        }
+        int lpPerPp = lcpus / physProcs;


it seems that lpPerPp can become 0... eg. 1/2, 1/3... and then cause a divide by zero on line 132.

see #2228
explainer https://stackoverflow.com/questions/4685450/int-division-why-is-the-result-of-1-3-0

explainer https://stackoverflow.com/questions/4685450/int-division-why-is-the-result-of-1-3-0

Better explainer: https://xkcd.com/2295/

Add Cache API, implement on Windows

b459610

dbwiddis mentioned this pull request Sep 28, 2022

CPU Cache #2190

Closed

sonatype-lift Bot reviewed Sep 28, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/driver/windows/LogicalProcessorInformation.java Outdated

sonatype-lift Bot reviewed Sep 28, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/platform/unix/aix/AixCentralProcessor.java

sonatype-lift Bot reviewed Sep 28, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/platform/unix/aix/AixCentralProcessor.java

sonatype-lift Bot reviewed Sep 28, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/platform/mac/MacCentralProcessor.java

dbwiddis added 4 commits September 27, 2022 22:28

Account for multiple caches per processor

b456596

Make cache type an enum

ca40647

Fix failing tests on silly assumption

d6405a8

Add Linux implementation

4942e60

sonatype-lift Bot reviewed Oct 2, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/platform/linux/LinuxCentralProcessor.java

Improve Cache toString

502b47c

dbwiddis mentioned this pull request Oct 2, 2022

Allow suppressing sysctl error for known error conditions #2206

Closed

Implement on AIX

d0b04e8

sonatype-lift Bot reviewed Oct 2, 2022

View reviewed changes

dbwiddis added 2 commits October 2, 2022 16:11

Actually return caches from the init method

4e15818

getAnswerAt is 0-based.

9f2fc7c

sonatype-lift Bot reviewed Oct 2, 2022

View reviewed changes

sonatype-lift Bot reviewed Oct 3, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/driver/windows/LogicalProcessorInformation.java

sonatype-lift Bot reviewed Oct 3, 2022

View reviewed changes

dbwiddis force-pushed the cache branch from 9f8fdcf to 512853b Compare October 3, 2022 03:35

Remove unnecessary redundancy

abae668

dbwiddis force-pushed the cache branch from 512853b to abae668 Compare October 3, 2022 03:44

OpenBSD implementation (without hybrid cores)

a2df151

sonatype-lift Bot reviewed Oct 3, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/CentralProcessor.java

sonatype-lift Bot reviewed Oct 3, 2022

View reviewed changes

Comment thread oshi-core/src/main/java/oshi/hardware/common/AbstractCentralProcessor.java

dbwiddis added 2 commits October 3, 2022 16:39

Hybrid core implementation

d53d8a4

Fix compile error

853a697

FreeBSD implementation

c9e272a