Upgrade AllenNLP to v2.2.0#2528
Merged
toshihikoyanase merged 4 commits intooptuna:masterfrom Mar 29, 2021
himkt:hotfix/allennlp-2.2.0
Merged
Upgrade AllenNLP to v2.2.0#2528toshihikoyanase merged 4 commits intooptuna:masterfrom himkt:hotfix/allennlp-2.2.0
v2.2.0#2528toshihikoyanase merged 4 commits intooptuna:masterfrom
himkt:hotfix/allennlp-2.2.0
Conversation
crcrpar
approved these changes
Mar 28, 2021
| run: | | ||
| pytest --cov=optuna --cov-report=xml tests \ | ||
| --ignore tests/integration_tests/allennlp_tests | ||
| pytest --cov=optuna --cov-report=xml tests |
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your PR.
The change basically looks good to me, but I added comments on Python 3.6.
Co-authored-by: Toshihiko Yanase <toshihiko.yanase@gmail.com>
Co-authored-by: Toshihiko Yanase <toshihiko.yanase@gmail.com>
Member
Author
|
@toshihikoyanase Thank you for the catch. 🙇 |
toshihikoyanase
approved these changes
Mar 29, 2021
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your update. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-introduces AllenNLP to the dependencies.
(AllenNLP v2.2.0 supports PyTorch v1.8.0)
Motivation
setup.pyDescription of the changes
setup.py(
verifying on himkt#13, after the examples finish successfully, I'll remove WIP=> done!)