Support object representation of StudyDirection for create_study arguments#2516
Merged
toshihikoyanase merged 4 commits intooptuna:masterfrom Mar 25, 2021
Merged
Conversation
g-votte
commented
Mar 24, 2021
hvy
approved these changes
Mar 24, 2021
Member
hvy
left a comment
There was a problem hiding this comment.
Thanks, LGTM! Left a minor comment but it's mostly a cosmetic.
Codecov Report
@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
- Coverage 89.80% 89.78% -0.02%
==========================================
Files 135 135
Lines 11310 11310
==========================================
- Hits 10157 10155 -2
- Misses 1153 1155 +2
Continue to review full report at Codecov.
|
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your PR. This feature definitely improves the usability of optuna.create_study.
The change looks good to me, but I have a small comment on the error message.
toshihikoyanase
approved these changes
Mar 25, 2021
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your update. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables to pass
StudyDirectionobjects to thedirection/directionsargument ofoptuna.create_study.Motivation
Supporting
StudyDirectionobjects sometimes simplifies the user’s code especially when the user already has theStudyDirectionobjects when creating the study, e.g., copying an existing study to new one as follows.Note that the code above raises an error in the second line without applying this PR, and the user has to convert the direction objects to the string representation.