(bugfix): update operator-sdk run bundle(-upgrade) to ignore channels in the bundle and use a default one#6042
Merged
everettraven merged 9 commits intoSep 28, 2022
Conversation
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Member
|
Retitle the bug to be something meaningful |
operator-sdk run bundle(-upgrade) to ignore channels in the bundle and use a default one
Contributor
Author
Updated. meant to do that before opening the PR but must've forgot :) |
dacamposol
pushed a commit
to dacamposol/operator-sdk
that referenced
this pull request
Oct 6, 2022
…ls in the bundle and use a default one (operator-framework#6042) * fix run bundle(-upgrade) to no longer stall Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add changelog Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add err check and log warning for linter Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update run bundle(-upgrade) to use a default channel Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update channel name checks Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add changelog Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update changelog Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
operator-sdk run bundle(-upgrade)ignore channel information from a bundle and instead either use a default value ofoperator-sdk-run-bundleor the one specified in an existingSubscriptionCR.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs