Skip to content

Support test selection in scorecard-kuttl integration#6015

Merged
jmrodri merged 4 commits into
operator-framework:masterfrom
jmrodri:kuttl
Sep 10, 2022
Merged

Support test selection in scorecard-kuttl integration#6015
jmrodri merged 4 commits into
operator-framework:masterfrom
jmrodri:kuttl

Conversation

@jmrodri

@jmrodri jmrodri commented Sep 3, 2022

Copy link
Copy Markdown
Member

Description of the change:
Update the entrypoint to use the test name passed in from the test config.

Motivation for the change:
Fixes #5743

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri
Add BUILDPLATFORM arg to the Dockerfile
5c8117e 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri
Handle specific test in the entrypoint
39bdb5e 
* Add comments and cleanup script

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:14 Inactive
@jmrodri
Add changelog entry
19cf328 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:37 Inactive
@jmrodri

jmrodri commented Sep 3, 2022

Copy link
Copy Markdown
Member Author

We're going to need a new release of the scorecard-test-kuttl image for folks to be able to use the changes in this PR.

@jmrodri
Bump kuttl to v0.12.1
402b207 
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri temporarily deployed to deploy September 3, 2022 04:55 Inactive
@jmrodri jmrodri requested review from theishshah and removed request for fabianvf September 3, 2022 04:57
@jmrodri

jmrodri commented Sep 3, 2022

Copy link
Copy Markdown
Member Author 
[jesusr@transam memcached-operator{kuttl-debug-commits}]$ operator-sdk scorecard ./bundle  --service-account kuttl-user --wait-time 60s --selector='suite=smoke-suite' --skip-cleanup
--------------------------------------------------------------------------------
Image:      quay.io/jesusr/scorecard-test-kuttl:dev
Entrypoint: [entrypoint common smoke]
Labels:
        "cluster-size":"small"
        "phase":"msp-main"
        "suite":"smoke-suite"
        "test":"smoke"
        "cluster-product":"ocp"
Results:
        Name: smoke
        State: pass

everettraven
everettraven approved these changes Sep 6, 2022
View reviewed changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me. Not to familiar with the scorecard stuff though so I will leave any LGTMs up to others that are more familiar with it.

laxmikantbpandhare
laxmikantbpandhare approved these changes Sep 7, 2022
View reviewed changes

@laxmikantbpandhare laxmikantbpandhare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@jmrodri jmrodri merged commit bd17840 into operator-framework:master Sep 10, 2022
dacamposol pushed a commit to dacamposol/operator-sdk that referenced this pull request Oct 6, 2022
@jmrodri @dacamposol
Support test selection in scorecard-kuttl integration (operator-frame…
bfdb47f 
…work#6015)

* Add BUILDPLATFORM arg to the Dockerfile
* Handle specific test in the entrypoint
* Add comments and cleanup script
* Add changelog entry
* Bump kuttl to v0.12.1

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@theishshah theishshah Awaiting requested review from theishshah

+1 more reviewer

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@laxmikantbpandhare laxmikantbpandhare

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test selection in kuttl scorecard image is ignored and all the test are actually run

3 participants

@jmrodri @everettraven @laxmikantbpandhare