Skip to content

Add docs for PR process.#6264

Merged
rashmigottipati merged 1 commit into
operator-framework:masterfrom
jberkhahn:pr_docs
Jan 26, 2023
Merged

Add docs for PR process.#6264
rashmigottipati merged 1 commit into
operator-framework:masterfrom
jberkhahn:pr_docs

Conversation

@jberkhahn

Copy link
Copy Markdown
Contributor

Fixes #5685

Hopefully my markdown is right.

must be approved by 2 reviewers, one of which must be at least at least a reviewer and one
of which must be at least an approver, per the [Operator Framework community guidelines][of-contributor-ladder].

Please feel free to the developers to get eyes on your PR, whether through @'ing on the PR itself,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?:

Suggested change
Please feel free to the developers to get eyes on your PR, whether through @'ing on the PR itself,
Please feel free to message the developers to get eyes on your PR, whether through @'ing on the PR itself,

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one typo this looks good to me!

Fixes operator-framework#5685

Signed-off-by: jberkhahn <jaberkha@us.ibm.com>
@jberkhahn

Copy link
Copy Markdown
Contributor Author

fixed the typo

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rashmigottipati rashmigottipati merged commit ce1159d into operator-framework:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for Pull request process

3 participants