Release v1.24.0#6071
Merged
Merged
Conversation
laxmikantbpandhare
suggested changes
Oct 8, 2022
laxmikantbpandhare
left a comment
Member
There was a problem hiding this comment.
We updated OLM versions in docs in another PR but looks like we missed updating at a few places.
Please check Bryce's PR for the 1.22 release - https://github.com/operator-framework/operator-sdk/pull/5876/files
Missing places:
internal/bindata/olm/versions.go
internal/testutils/olm.go
laxmikantbpandhare
suggested changes
Oct 8, 2022
Member
I have 2 patches to fix sanity. You have to run it with go 1.18 for this to work. If you run it with 1.19 you will get what's in this PR. |
Member
|
Okay it was only one patch. That is run with go 1.18. |
Signed-off-by: Jonathan Berkhahn <jaberkha@us.ibm.com>
54d6c92 to
36fb597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this works