Add version check during task submission for bwc for static threshold setting#5633
Merged
shwetathareja merged 4 commits intoopensearch-project:mainfrom Dec 27, 2022
Merged
Conversation
e8c99a3 to
f4350cf
Compare
… setting Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
f4350cf to
d10d550
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5633 +/- ##
============================================
- Coverage 71.16% 70.94% -0.22%
+ Complexity 58621 58461 -160
============================================
Files 4757 4757
Lines 279194 279202 +8
Branches 40316 40318 +2
============================================
- Hits 198675 198078 -597
- Misses 64302 64875 +573
- Partials 16217 16249 +32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
shwetathareja
left a comment
There was a problem hiding this comment.
minor comments. thanks @dhwanilpatel
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
7fd120e to
31fb3a0
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
shwetathareja
approved these changes
Dec 27, 2022
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
shwetathareja
approved these changes
Dec 27, 2022
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dhwanil Patel dhwanip@amazon.com
Description
Changed version of the ClusterManagerThrottlingException.
BWC for thresholds set via static setting
When throttling threshold setting is set via static setting (yml) file, it can be updated and feature can throttle the task even when older nodes are present in cluster.
Added check on task submission of configured task for throttling to check for version check. If older nodes are present, it will not perform throttling to provide backward compatibility.
Once all nodes are higher than 2.5.0, it will start throttling based on threshold and wont be disabled again.
Issues Resolved
#479
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.