Support of GeoJson Point for GeoPoint field by heemin32 · Pull Request #4597 · opensearch-project/OpenSearch

heemin32 · 2022-09-26T17:06:00Z

See opensearch-project/geospatial#152

Signed-off-by: Heemin Kim heemin@amazon.com

Description

Supports GeoJson Point type in GeoPoint field

Issues Resolved

opensearch-project/geospatial#152

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-09-26T17:11:50Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3420/
CommitID: 70c61a3

github-actions · 2022-09-26T17:17:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3421/
CommitID: dcdb237

github-actions · 2022-09-26T18:01:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3426/
CommitID: 7dccc34

github-actions · 2022-09-26T19:42:32Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3434/
CommitID: 266e8f9

github-actions · 2022-09-26T21:46:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/3442/
CommitID: 9392b1a

github-actions · 2022-09-26T22:50:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3443/
CommitID: ae01de7

github-actions · 2022-09-27T00:35:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/3444/
CommitID: 5d8d760

heemin32 · 2022-10-03T17:33:17Z

Will raise another commit with more unit tests in GeoPointFieldMapperTests.

github-actions · 2022-10-11T17:52:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4418/
CommitID: c530d8e

github-actions · 2022-10-11T18:02:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4425/
CommitID: f1ac2ac

github-actions · 2022-10-13T18:17:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4604/
CommitID: ded7d9f

github-actions · 2022-10-17T17:08:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4788/
CommitID: e93d789

nknize

LGTM! Thx!

github-actions · 2022-10-19T04:32:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4911/
CommitID: afad3e0

opensearch-trigger-bot · 2022-10-19T18:27:56Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4597-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a282d399225247226d5abc3e3cd903462c973877
# Push it to GitHub
git push --set-upstream origin backport/backport-4597-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4597-to-2.x.

dblock · 2022-10-19T18:32:25Z

@heemin32 will need a manual backport to 2.x if you want this in a 2.x release

* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit a282d39)

heemin32 · 2022-10-19T18:55:42Z

@heemin32 will need a manual backport to 2.x if you want this in a 2.x release

Created backport PR. #4842

* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit a282d39)

) * Support of GeoJson Point for GeoPoint field (#4597) * Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit a282d39) * Run geojson yaml test for 2.4 and above only Signed-off-by: Heemin Kim <heemin@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com>

* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactored code based on comments Signed-off-by: Heemin Kim <heemin@amazon.com> * Add unit tests for GeoJson support Signed-off-by: Heemin Kim <heemin@amazon.com> * Resolve comments * Remove negation expression * Ignore case for GeoJson Point type to be consistent with geo_shape parsing Signed-off-by: Heemin Kim <heemin@amazon.com> * Added yaml test for geopoint Signed-off-by: Heemin Kim <heemin@amazon.com> Signed-off-by: Heemin Kim <heemin@amazon.com>

heemin32 requested review from a team and reta as code owners September 26, 2022 17:06

heemin32 force-pushed the geojson branch from 70c61a3 to dcdb237 Compare September 26, 2022 17:06

heemin32 force-pushed the geojson branch from dcdb237 to 7dccc34 Compare September 26, 2022 17:45

heemin32 force-pushed the geojson branch from 7dccc34 to 266e8f9 Compare September 26, 2022 19:19

heemin32 force-pushed the geojson branch from 266e8f9 to 9392b1a Compare September 26, 2022 21:28

heemin32 force-pushed the geojson branch from 9392b1a to ae01de7 Compare September 26, 2022 22:25

martin-gaievski reviewed Sep 26, 2022

View reviewed changes

heemin32 force-pushed the geojson branch from ae01de7 to 5d8d760 Compare September 27, 2022 00:10

naveentatikonda reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/test/java/org/opensearch/common/geo/PointParserTests.java Outdated

navneet1v reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/GeoUtils.java Outdated

navneet1v reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

navneet1v reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/test/java/org/opensearch/common/geo/PointParserTests.java Outdated

navneet1v reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/test/java/org/opensearch/common/geo/PointParserTests.java Outdated

VijayanB reviewed Sep 28, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/GeoPoint.java Outdated

VijayanB reviewed Sep 29, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

VijayanB reviewed Sep 29, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

VijayanB reviewed Sep 29, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

VijayanB reviewed Sep 29, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

VijayanB reviewed Sep 29, 2022

View reviewed changes

Comment thread server/src/main/java/org/opensearch/common/geo/PointParser.java Outdated

heemin32 force-pushed the geojson branch from 5d8d760 to 69d7336 Compare October 3, 2022 17:31

Merge branch 'main' into geojson

f1ac2ac

heemin32 mentioned this pull request Oct 12, 2022

Add geohex_grid aggregation opensearch-project/geospatial#160

Merged

1 task

Merge branch 'main' into geojson

ded7d9f

heemin32 requested review from nknize and removed request for VijayanB October 13, 2022 17:46

Merge branch 'main' into geojson

e93d789

nknize approved these changes Oct 18, 2022

View reviewed changes

Merge branch 'main' into geojson

afad3e0

reta approved these changes Oct 19, 2022

View reviewed changes

dblock approved these changes Oct 19, 2022

View reviewed changes

dblock merged commit a282d39 into opensearch-project:main Oct 19, 2022

dblock added the backport 2.x Backport to 2.x branch label Oct 19, 2022

heemin32 deleted the geojson branch October 24, 2022 22:08

heemin32 mentioned this pull request Oct 25, 2022

Fix a bug on handling an invalid array value for point type field #4900

Merged

6 tasks

Conversation

heemin32 commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Sep 26, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 27, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heemin32 commented Oct 3, 2022

Uh oh!

github-actions Bot commented Oct 11, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Oct 11, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Oct 13, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions Bot commented Oct 17, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

nknize left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

opensearch-trigger-bot Bot commented Oct 19, 2022

Uh oh!

dblock commented Oct 19, 2022

Uh oh!

heemin32 commented Oct 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

heemin32 commented Sep 26, 2022 •

edited

Loading