Skip to content

Added in-flight cancellation of SearchShardTask based on resource consumption#4565

Closed
ketanv3 wants to merge 1 commit intoopensearch-project:mainfrom
ketanv3:feature/inflight-cancellation-pr
Closed

Added in-flight cancellation of SearchShardTask based on resource consumption#4565
ketanv3 wants to merge 1 commit intoopensearch-project:mainfrom
ketanv3:feature/inflight-cancellation-pr

Conversation

@ketanv3
Copy link
Copy Markdown
Contributor

@ketanv3 ketanv3 commented Sep 21, 2022

Description

This feature aims to identify and cancel resource intensive SearchShardTasks if they have breached certain thresholds. This will help in terminating problematic queries which can put nodes in duress and degrade the cluster performance.

Issues Resolved

#1181

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ketan Verma ketan9495@gmail.com

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@ketanv3 ketanv3 force-pushed the feature/inflight-cancellation-pr branch 2 times, most recently from 7a7a952 to ad0454e Compare September 21, 2022 17:01
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@ketanv3 ketanv3 force-pushed the feature/inflight-cancellation-pr branch from ad0454e to 7786c5e Compare September 22, 2022 17:38
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

…sumption

This feature aims to identify and cancel resource intensive SearchShardTasks if they have breached certain
thresholds. This will help in terminating problematic queries which can put nodes in duress and degrade the
cluster performance.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
@ketanv3 ketanv3 force-pushed the feature/inflight-cancellation-pr branch from 7786c5e to 4a9abaf Compare September 22, 2022 21:01
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4565 (4a9abaf) into main (2c27dfd) will increase coverage by 0.12%.
The diff coverage is 77.14%.

@@             Coverage Diff              @@
##               main    #4565      +/-   ##
============================================
+ Coverage     70.51%   70.64%   +0.12%     
- Complexity    57310    57515     +205     
============================================
  Files          4628     4642      +14     
  Lines        276073   276579     +506     
  Branches      40421    40466      +45     
============================================
+ Hits         194677   195378     +701     
+ Misses        65103    64825     -278     
- Partials      16293    16376      +83     
Impacted Files Coverage Δ
...min/cluster/stats/TransportClusterStatsAction.java 70.83% <ø> (ø)
...ain/java/org/opensearch/cluster/ClusterModule.java 100.00% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...ain/java/org/opensearch/tasks/CancellableTask.java 82.35% <ø> (-5.89%) ⬇️
...search/cluster/MockInternalClusterInfoService.java 0.00% <0.00%> (ø)
.../java/org/opensearch/test/InternalTestCluster.java 60.72% <ø> (-1.50%) ⬇️
...rch/action/admin/cluster/node/stats/NodeStats.java 50.67% <33.33%> (-1.13%) ⬇️
...src/main/java/org/opensearch/node/NodeService.java 72.41% <33.33%> (-0.81%) ⬇️
...arch/backpressure/trackers/ElapsedTimeTracker.java 61.29% <61.29%> (ø)
.../search/backpressure/trackers/CpuUsageTracker.java 62.06% <62.06%> (ø)
... and 502 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ketanv3 ketanv3 closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants