Add config.rejectPublicKeyAlgorithms#1264
Merged
twiss merged 13 commits intoopenpgpjs:masterfrom Mar 25, 2021
Merged
Conversation
Contributor
|
Excellent! |
twiss
reviewed
Mar 10, 2021
Member
twiss
left a comment
There was a problem hiding this comment.
👍 Thanks, looks good! Small nitpicks below 😊
292d04f to
2f04938
Compare
twiss
reviewed
Mar 18, 2021
twiss
reviewed
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
config.rejectPublicKeyAlgorithmsto disallow using the given algos to verify, sign or encrypt new messages or third-party certificationsconfig.minRsaBitswhen signing, verifying and encrypting messages and third-party certifications, not just on key generationsignaturewill havesignature.valid=false(used to besignature.valid=null).signature.errorwill detail whether the key is missing/too weak/other.Generating and verifying key certification signatures is still permitted in all cases.