Add config.rejectCurves and prevent generating keys using blacklisted algos#1395
Merged
larabr merged 4 commits intoopenpgpjs:masterfrom Aug 19, 2021
Merged
Add config.rejectCurves and prevent generating keys using blacklisted algos#1395larabr merged 4 commits intoopenpgpjs:masterfrom
config.rejectCurves and prevent generating keys using blacklisted algos#1395larabr merged 4 commits intoopenpgpjs:masterfrom
Conversation
efb2c04 to
df2a069
Compare
larabr
commented
Aug 6, 2021
twiss
reviewed
Aug 19, 2021
…public key algo and curves
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
twiss
approved these changes
Aug 19, 2021
38b9faf to
28f035a
Compare
larabr
added a commit
that referenced
this pull request
Dec 1, 2021
Breaking change: when generating new subkeys through `key.addSubkey()`, we now check `config.rejectCurves` and prevent adding subkeys using the corresponding curves. By default, `config.rejectCurves` includes the brainpool curves (`brainpoolP256r1`, `brainpoolP384r1`, `brainpoolP512r1`) and the Bitcoin curve (`secp256k1`). This is a follow up to #1395 , which introduced the same check to `openpgp.generateKey`.
This was referenced Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
config.rejectPublicKeyAlgorithms;config.rejectCurvesto blacklist a set of ECC curves, to prevent keys using those curves from being generated, or being used to encrypt/decrypt/sign/verify messages.By default,
config.rejectCurvesincludes the brainpool curves (brainpoolP256r1,brainpoolP384r1,brainpoolP512r1) and the Bitcoin curve (secp256k1). This is because it's unclear whether these curves will be standardised, and we prefer to blacklist them already, rather than introduce a breaking change after release.