This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Fix video recording.#2139
Merged
pzhokhov merged 1 commit intoopenai:masterfrom Jan 11, 2021
Merged
Conversation
|
Thank you ! Fixes it for me too, tested with this : import gym
env = gym.make('CartPole-v0')
env = gym.wrappers.Monitor(env, "recording", force=True)
env.reset()
while True:
obs, rew, done, info = env.step(env.action_space.sample())
if done:
break |
japonophile
approved these changes
Jan 3, 2021
Closed
feiden
approved these changes
Jan 6, 2021
feiden
left a comment
There was a problem hiding this comment.
I stumbled on this problem by chance, and almost submitted the exact same bug fix. Approve!
pzhokhov
approved these changes
Jan 11, 2021
|
I already fix the code but still have same problem(262bytes), can I ask why? |
Oh! I see, if you change the code, you need reboot your PC to activate the change. I reboot and succeed! |
This was referenced Mar 17, 2021
|
Why is this not released yet? |
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with
python examples/agents/random_agent.py. The code before the change would create empty video files.