Integrate go-build-tools crosslink#2886
Merged
MrAlias merged 10 commits intoopen-telemetry:mainfrom May 6, 2022
Merged
Conversation
added 8 commits
May 4, 2022 11:55
Codecov Report
@@ Coverage Diff @@
## main #2886 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 177 177
Lines 11819 11819
=====================================
+ Hits 8950 8954 +4
+ Misses 2636 2632 -4
Partials 233 233
|
MrAlias
approved these changes
May 5, 2022
Member
At first glance, it seems the most effective approach. Any downsides if we do that? |
Contributor
Author
There really isn't any in this context. While it's a destructive action the repository is already under version control so it's all completely reversible. Also, continually pruning would ensure that the |
pellared
approved these changes
May 5, 2022
hanyuancheung
approved these changes
May 6, 2022
MrAlias
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
crosslinktarget to reference thego.opentelemetry.io/build-tools/crosslinkpackage found here.I have also ran
crosslink pruneto remove all the extraneous replace statements. No make target was added forcrosslink prunebut if desired we could either add a new target for that or pass in the--pruneflag so that a prune is executed on every run.Fixes #1529