add additional batch overhead in jaeger agent udp exporter#2489
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Jan 4, 2022
Merged
add additional batch overhead in jaeger agent udp exporter#2489MrAlias merged 3 commits intoopen-telemetry:mainfrom
MrAlias merged 3 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Aneurysm9
approved these changes
Jan 3, 2022
Member
Aneurysm9
left a comment
There was a problem hiding this comment.
Please add a CHANGELOG.md entry describing this change.
Codecov Report
@@ Coverage Diff @@
## main #2489 +/- ##
=======================================
- Coverage 76.3% 76.3% -0.1%
=======================================
Files 173 173
Lines 12022 12022
=======================================
- Hits 9179 9173 -6
- Misses 2598 2604 +6
Partials 245 245
|
MrAlias
approved these changes
Jan 3, 2022
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
dashpole
approved these changes
Jan 4, 2022
This was referenced Jan 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Fixes #2465
This pr adds the additional batch overhead to max packet size mentioned in #2465 (comment).