Skip to content

[Prometheus] Update changelog and minor cleanup.#3512

Merged
utpilla merged 11 commits intoopen-telemetry:mainfrom
Yun-Ting:yunl/cleanup
Aug 2, 2022
Merged

[Prometheus] Update changelog and minor cleanup.#3512
utpilla merged 11 commits intoopen-telemetry:mainfrom
Yun-Ting:yunl/cleanup

Conversation

@Yun-Ting
Copy link
Copy Markdown
Contributor

@Yun-Ting Yun-Ting commented Aug 1, 2022

Changes

Update changelog and minor cleanup.

@Yun-Ting Yun-Ting marked this pull request as ready for review August 1, 2022 18:23
@Yun-Ting Yun-Ting requested a review from a team August 1, 2022 18:23
Comment thread src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2022

Codecov Report

Merging #3512 (504b639) into main (6c616c1) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 504b639 differs from pull request most recent head 2c41225. Consider uploading reports for the commit 2c41225 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3512      +/-   ##
==========================================
- Coverage   86.73%   86.66%   -0.08%     
==========================================
  Files         275      275              
  Lines        9963     9963              
==========================================
- Hits         8641     8634       -7     
- Misses       1322     1329       +7     
Impacted Files Coverage Δ
.../PrometheusExporterApplicationBuilderExtensions.cs 100.00% <ø> (ø)
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <ø> (ø)
...metheus.AspNetCore/PrometheusExporterMiddleware.cs 67.85% <ø> (ø)
....Prometheus.HttpListener/PrometheusHttpListener.cs 81.57% <100.00%> (ø)
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+1.09%) ⬆️

Comment thread src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style inconsistency.

Comment thread src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md Outdated
@utpilla utpilla merged commit f97d338 into open-telemetry:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants