Skip to content

Nit fixed in prometheus for asp.net core#3510

Merged
cijothomas merged 1 commit intoopen-telemetry:mainfrom
cijothomas:cijothomas/prometheus-aspnetcore-nit1
Aug 1, 2022
Merged

Nit fixed in prometheus for asp.net core#3510
cijothomas merged 1 commit intoopen-telemetry:mainfrom
cijothomas:cijothomas/prometheus-aspnetcore-nit1

Conversation

@cijothomas
Copy link
Copy Markdown
Member

@cijothomas cijothomas commented Aug 1, 2022

Also the code has many NETCOREAPP3_1_OR_GREATER, which can also be removed.

@cijothomas cijothomas requested a review from a team August 1, 2022 17:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2022

Codecov Report

Merging #3510 (11cdbaa) into main (084244c) will decrease coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   86.67%   86.58%   -0.09%     
==========================================
  Files         275      275              
  Lines        9970     9963       -7     
==========================================
- Hits         8641     8626      -15     
- Misses       1329     1337       +8
Impacted Files Coverage Δ
.../PrometheusExporterApplicationBuilderExtensions.cs 100.00% <ø> (ø)
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <ø> (ø)
...metheus.AspNetCore/PrometheusExporterMiddleware.cs 67.85% <ø> (ø)
...Prometheus.AspNetCore/PrometheusExporterOptions.cs 50.00% <ø> (ø)
...Listener/Internal/PrometheusExporterEventSource.cs 27.77% <ø> (ø)
...heus.HttpListener/Internal/PrometheusSerializer.cs 78.21% <ø> (ø)
...s.HttpListener/Internal/PrometheusSerializerExt.cs 100.00% <ø> (ø)
...theusHttpListenerMeterProviderBuilderExtensions.cs 58.33% <66.66%> (ø)
...rometheusExporterMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <100.00%> (ø)
... and 7 more

@cijothomas cijothomas merged commit 6c616c1 into open-telemetry:main Aug 1, 2022
@cijothomas cijothomas deleted the cijothomas/prometheus-aspnetcore-nit1 branch August 1, 2022 18:12
@cijothomas cijothomas mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwest alanwest alanwest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cijothomas @alanwest