Add LpPool-18 - add ceil_mode and dilations attributes#4534
Merged
gramalingam merged 11 commits intoonnx:mainfrom Nov 22, 2022
Merged
Add LpPool-18 - add ceil_mode and dilations attributes#4534gramalingam merged 11 commits intoonnx:mainfrom
ceil_mode and dilations attributes#4534gramalingam merged 11 commits intoonnx:mainfrom
Conversation
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
This was referenced Sep 22, 2022
|
I don't see why explicit In my experience, when writing a backend, such coverage tests are very valuable, partly as a safety net but also as additional documentation / clarification. I can not see any big cost in adding such tests, except of course for the initial effort of writing them. |
gramalingam
reviewed
Sep 27, 2022
Contributor
|
Agree with @kraiskil ... adding the test-cases would be useful. |
Contributor
|
Why not add the |
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Contributor
Author
|
@kraiskil @gramalingam I'm working on both adding tests and adding |
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
p-wysocki
commented
Nov 9, 2022
ceil_mode attributeceil_mode and dilations attributes
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
gramalingam
approved these changes
Nov 17, 2022
justinchuby
pushed a commit
to justinchuby/onnx
that referenced
this pull request
Jan 27, 2023
* Add LpPool-18 Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Rework adapter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor changes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add shape inference tests for dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Add LpPool-18 Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Rework adapter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor changes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add shape inference tests for dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: p-wysocki przemyslaw.wysocki@intel.com
Description
Add
LpPool-18, which now hasceil_modeanddilationsattributes. Deprecateauto_pad, like it is done in the case of AveragePool and MaxPool.Motivation and Context
Notes
ceil_modeattribute. As far as I understand, it makes adding the attribute toceil_modetrivial, as it is done in this PR. The same goes for thedilationsattribute.LpPoolare non-existent (there is not such a file asonnx/onnx/backend/test/case/node/lppool.py). Is it intentional? Pooling operators seem to have a lot of common code, so maybeLpPoolis considered to be covered by tests forMaxPoolandAveragePool. I am not sure if it is intended or an overlook.A related PR concerns removing
storage_orderattribute from the MaxPool operator: Add MaxPool-18 - removestorage_orderattribute #4533.