Skip to content

Add requirement.txt for ONNX's dependency#3448

Merged
askhade merged 36 commits intoonnx:masterfrom
jcwchen:add-require
Jul 20, 2021
Merged

Add requirement.txt for ONNX's dependency#3448
askhade merged 36 commits intoonnx:masterfrom
jcwchen:add-require

Conversation

@jcwchen
Copy link
Copy Markdown
Member

@jcwchen jcwchen commented Apr 22, 2021 •
edited
Loading

Description

  • Add ONNX's dependency as requirement.txt
    • requirement.txt: for build
    • requirement-release.txt: for release (fixed dependency version)
    • requirement-dev.txt : for development (testing)
  • To improve maintainability, reuse requirement-release.txt in all release CIs to sync dependency version easily
  • Add missing -q for each pip install

Motivation
requirement*.txt is useful for users to understand ONNX's dependency.

jcwchen added 10 commits April 21, 2021 07:58
@jcwchen
fix ort failure and add manually trigger
9e64691 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
fix syntax error
f5faf4b 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
add master trigger first
078d571 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge pull request #7 from jcwchen/fix-ort
432acb4 
Fix ort
@jcwchen
pip install flatbuffers
802e2c0 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
apply it to all CIs
55f2207 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge pull request #8 from jcwchen/fix-ort
901563e 
Add dispatch to all CIs
@jcwchen
add requirement
20ea9f3 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
use requirement for install_require
ef68907 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
add six and typin-ext in .dev
d3c9d58 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen requested a review from a team as a code owner April 22, 2021 15:48
jcwchen added 2 commits April 22, 2021 13:09
@jcwchen
reuse requirement-release.txt
9c005de 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge remote-tracking branch 'upstream/master' into add-require
9337b17 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

# Conflicts:
#	.github/workflows/manylinux/test_package_i686.sh
#	.github/workflows/release_win.yml
jcwchen added 2 commits April 22, 2021 13:21
@jcwchen
update requreiment-release.txt
328f073 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
install protobuf 3.11.3 after installing protobuf-compiler
846b805 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen added module: CI pipelines Issues related to the CI pipeline topic: build Issues related to ONNX builds and packages labels Apr 22, 2021
jcwchen added 5 commits April 22, 2021 14:00
@jcwchen
install protobuf 3.11.3 rb
089be1c 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
install protobuf without brew
bacf0db 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge branch 'master' into add-require
cdd0d8d
@jcwchen
remove conda install in Mac-CI
e48b094 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge branch 'add-require' of https://github.com/jcwchen/onnx into ad…
6a3855f 
…d-require
@jcwchen
do not use requirements.txt in i686
a3d05e5 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen enabled auto-merge (squash) April 30, 2021 14:15
@jcwchen jcwchen disabled auto-merge April 30, 2021 14:16
@jcwchen jcwchen mentioned this pull request May 10, 2021
Merged
@jcwchen jcwchen added the run release CIs Use this label to trigger release tests in CI label May 21, 2021
@jcwchen jcwchen mentioned this pull request Jun 10, 2021
Closed
annajung
annajung reviewed Jun 25, 2021
View reviewed changes
Comment thread .azure-pipelines/MacOS-CI.yml
git submodule update --init --recursive
python -m pip install --upgrade setuptools
python -m pip install numpy
conda install -y -c conda-forge pybind11 protobuf
Copy link
Copy Markdown
Member

@annajung annajung Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that pybind11 was removed, is this no longer necessary here?

Copy link
Copy Markdown
Member Author

@jcwchen jcwchen Jun 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually ONNX uses pybind11 as a submodule so basically it should not need to manually install pybind11 for ONNX

jcwchen added 7 commits June 27, 2021 18:08
@jcwchen
Merge branch 'master' into add-require
22237ea
@jcwchen
ipython==7.16.1
df96f7d 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
use latest numpy to prevent timeout
dedbd1d 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
Merge branch 'master' into add-require
8bb3dbd
@jcwchen
Merge branch 'master' into add-require
c1edb77
@jcwchen
bump protobuf to 3.16.0
ee0968f 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen
remove all 3.11.3
7ba9178 
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen added this to the 1.10 milestone Jul 15, 2021
rajeevsrao
rajeevsrao reviewed Jul 16, 2021
View reviewed changes
Comment thread requirements.txt Outdated
@askhade askhade merged commit 27be295 into onnx:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@annajung annajung annajung left review comments

@rajeevsrao rajeevsrao rajeevsrao approved these changes

@askhade askhade askhade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages

Projects

None yet

Milestone

1.10

Development

Successfully merging this pull request may close these issues.

4 participants

@jcwchen @rajeevsrao @askhade @annajung