Skip to content

remove optimizer related codes#3288

Merged
askhade merged 5 commits intoonnx:masterfrom
daquexian:remove_optimizer
Mar 15, 2021
Merged

remove optimizer related codes#3288
askhade merged 5 commits intoonnx:masterfrom
daquexian:remove_optimizer

Conversation

@daquexian
Copy link
Copy Markdown
Member

@daquexian daquexian commented Feb 21, 2021 •
edited
Loading

Remove optimizer-related codes including onnx.optimizer, onnx.utils.polish_model, their docs and jupyter notebooks

@daquexian
remove optimizer related codes
9a2921e 
Signed-off-by: daquexian <daquexian566@gmail.com>
@daquexian daquexian requested a review from a team as a code owner February 21, 2021 03:10
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Feb 21, 2021

This pull request fixes 1 alert when merging 9a2921e into fde37df - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@jcwchen jcwchen mentioned this pull request Feb 22, 2021
Closed
askhade
askhade reviewed Feb 22, 2021
View reviewed changes
Comment thread onnx/utils.py
from onnx import ModelProto, NodeProto, TensorProto, ValueInfoProto


def polish_model(model): # type: (ModelProto) -> ModelProto
Copy link
Copy Markdown
Contributor

@askhade askhade Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can keep this method just remove optimize and the checker call after optimize...

Copy link
Copy Markdown
Member Author

@daquexian daquexian Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so this method will only run strip_doc_string and shape_inference. It makes this method not so useful. What's your opinion? Thanks!

jcwchen
jcwchen approved these changes Feb 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the transfer!

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Feb 23, 2021

This pull request fixes 1 alert when merging 73601f2 into 722f5a4 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@linkerzhang linkerzhang requested a review from houseroad March 1, 2021 07:03
linkerzhang
linkerzhang approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@linkerzhang linkerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Jianhao.

@houseroad please double check this change. The optimizer now is moved to a separate repo under onnx org.

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Mar 1, 2021

This pull request fixes 1 alert when merging 91a10c6 into 1cbd549 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@askhade askhade added this to the 1.9 milestone Mar 9, 2021
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Mar 9, 2021

This pull request fixes 1 alert when merging ba4ce9e into 184aec5 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@askhade askhade merged commit 03e6c8f into onnx:master Mar 15, 2021
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Mar 15, 2021

This pull request fixes 1 alert when merging 02f1fb2 into 4f8ebec - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@etusien etusien mentioned this pull request Mar 31, 2021
Closed
@svenkreiss svenkreiss mentioned this pull request Apr 20, 2021
Merged
svenkreiss added a commit to openpifpaf/openpifpaf that referenced this pull request Apr 20, 2021
@svenkreiss
onnx 1.9 compatibility (#398)
c516dde 
ONNX: removed optimizer and polish, onnx/onnx#3288
@leoll2 leoll2 mentioned this pull request Apr 21, 2021
Closed
This was referenced Jan 7, 2022
Closed
Closed
@jcwchen jcwchen mentioned this pull request Feb 21, 2022
Closed
@AmitMY AmitMY mentioned this pull request Jun 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gramalingam gramalingam gramalingam approved these changes

@houseroad houseroad Awaiting requested review from houseroad

+3 more reviewers

@linkerzhang linkerzhang linkerzhang approved these changes

@askhade askhade askhade approved these changes

@jcwchen jcwchen jcwchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

5 participants

@daquexian @linkerzhang @askhade @gramalingam @jcwchen