fix bug that ir_pb_converter introduces empty shape#3279
Merged
linkerzhang merged 6 commits intoonnx:masterfrom Feb 20, 2021
Merged
fix bug that ir_pb_converter introduces empty shape#3279linkerzhang merged 6 commits intoonnx:masterfrom
linkerzhang merged 6 commits intoonnx:masterfrom
Conversation
Signed-off-by: daquexian <daquexian566@gmail.com>
askhade
reviewed
Feb 16, 2021
| value_by_name_of[gp.output(i).name()]->setSizes( | ||
| tensorShapeProtoToDimensions( | ||
| gp.output(i).type().tensor_type().shape())); | ||
| const auto output_tensor_type = gp.output(i).type().tensor_type(); |
askhade
reviewed
Feb 16, 2021
| value_by_name_of[gp.value_info(i).name()]->setElemType( | ||
| gp.value_info(i).type().tensor_type().elem_type()); | ||
| if (gp.value_info(i).type().tensor_type().has_shape()) { | ||
| const auto tensor_type = gp.value_info(i).type().tensor_type(); |
Signed-off-by: daquexian <daquexian566@gmail.com>
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
added a commit
to onnx/optimizer
that referenced
this pull request
Feb 17, 2021
Signed-off-by: daquexian <daquexian566@gmail.com>
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
added a commit
to onnx/optimizer
that referenced
this pull request
Feb 17, 2021
Signed-off-by: daquexian <daquexian566@gmail.com>
askhade
approved these changes
Feb 18, 2021
linkerzhang
approved these changes
Feb 20, 2021
neginraoof
pushed a commit
to neginraoof/onnx
that referenced
this pull request
Feb 22, 2021
* fix bug that introducing empty shape Signed-off-by: daquexian <daquexian566@gmail.com> * const auto -> const auto& Signed-off-by: daquexian <daquexian566@gmail.com> * fix bug about ValueInfoProto and Dimension Signed-off-by: daquexian <daquexian566@gmail.com> * fix more inconsistence Signed-off-by: daquexian <daquexian566@gmail.com> Co-authored-by: Ke Zhang <linkerzhang@yeah.net> Signed-off-by: neginraoof <neginmr@utexas.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves microsoft/onnxruntime#6691
Dimensionto cover unknown dimension