Add programmatic access to version-table and extend make-model#2918
Add programmatic access to version-table and extend make-model#2918gramalingam merged 24 commits intoonnx:masterfrom
Conversation
prasanthpul
left a comment
There was a problem hiding this comment.
can you add a cross reference between this script and the versioning doc at https://github.com/onnx/onnx/blob/master/docs/Versioning.md#released-versions
Whenever one is updated, the other needs to be updated too.
Done, thanks. |
|
This is very useful for #2912 thanks!. Just one concern. Regarding I can't find Since @prasanthpul mentioned this:
I thought it would be appropriate to bring this up here. |
|
@alrevuelta : that's a good question. I merely copied the text document over. May be this is the history, and perhaps not all versions were published. @prasanthpul , do you know? Should we do something different for those versions? |
…onnx into irversion-july-2020
|
Circle CI is fixed now. Merging with master should resolve the failure |
| 1.6.0|6|11|2|- | ||
| 1.7.0|7|12|2|1 | ||
|
|
||
| A programmatically accessible version of the above table is available [here](../onnx/helper.py). Limited version number |
There was a problem hiding this comment.
Why we need a text here? You should update "https://github.com/onnx/onnx/blob/master/docs/OnnxReleases.md".
There was a problem hiding this comment.
Thanks for the suggestion. I updated the OnnxReleases.md file also.
| namespace ONNX_NAMESPACE { | ||
|
|
||
| // Represents the most recent release version. Updated with every release. | ||
| constexpr const char* LAST_RELEASE_VERSION = "1.7.0"; |
There was a problem hiding this comment.
Can we read it from: https://github.com/onnx/onnx/blob/master/VERSION_NUMBER?
There was a problem hiding this comment.
We can't read that file at run-time, right? The one thing we could do is to auto-generate one file from the other. But that seems non-trivial and not worth it (at this point).
There was a problem hiding this comment.
(Summarizing an offline discussion.) Can we make auto-generation of these files a separate task and do it in a separate PR? It will be better to decide on a solution for all the version-numbers in multiple files, instead of just for this one file.
|
@ebarsoum @gramalingam what is the status on this? The changes look good to me and I am ok with adding auto-generation as part of a separate PR. |
|
I am also fine with completing this PR. |
|
I mentioned this some weeks ago but it didn't got much attention. Can someone have a look? Is it right?
|
…2918) * Add programmatic access to version-table * Add cross-links between documentation and code * Address flake8 warnings * add more tests * add last release opset version map * Add version.h * Update Versioning.md * add python type annotations * fix typecheck * add comment * address flake8 warnings * fix typing * Address PR feedback Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Emad Barsoum <ebarsoum@gmail.com>
…2918) * Add programmatic access to version-table * Add cross-links between documentation and code * Address flake8 warnings * add more tests * add last release opset version map * Add version.h * Update Versioning.md * add python type annotations * fix typecheck * add comment * address flake8 warnings * fix typing * Address PR feedback Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Emad Barsoum <ebarsoum@gmail.com> Signed-off-by: daquexian <daquexian566@gmail.com>
…2918) * Add programmatic access to version-table * Add cross-links between documentation and code * Address flake8 warnings * add more tests * add last release opset version map * Add version.h * Update Versioning.md * add python type annotations * fix typecheck * add comment * address flake8 warnings * fix typing * Address PR feedback Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Emad Barsoum <ebarsoum@gmail.com>
The existing version of make-model uses the latest IR-VERSION as the IR version if the caller does not explicitly supply an IR version. This PR makes the version-table available for programmatic access (in Python) and provides an extended version of make-model that generates the minimum required version from the opsets specified (on a best-effort basis).