Fix attribute substitution within subgraphs during function type/shape inference by gramalingam · Pull Request #4792 · onnx/onnx

gramalingam · 2023-01-19T22:36:27Z

Description

Fix bug in shape inference.

Motivation and Context

Attribute parameter substitution, during inference for a function body, does not recursively do the substitution within subgraphs of control-flow constructs.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

wschin · 2023-01-19T23:00:33Z

+    for (auto attr_iter = attributes.begin(); attr_iter != attributes.end();) {
+      auto& attr = *attr_iter;
+      if (!attr.ref_attr_name().empty()) {
+        // Attribute-references must be replaced by the corresponding attribute-value in the call-node


What is "call-node"?

It is a node representing a call to this function. For example, in our test-case, it is the node in the main graph representing y = local.cast<target=6>(x). It specifies the attribute-value for target, which is used in the replacement.

wschin · 2023-01-19T23:03:50Z

+          // Copy value of attribute, but retain original name:
+          std::string name = attr.name();
+          attr = *(entry->second);
+          attr.set_name(name);


Is the resulted graph still valid if the original attribute name is reused? This sounds a name conflict.

Consider the line y = Cast<to:int = @target> (x) from the test-case in this PR. Here, target is an attribute-parameter of the containing function. After we do substitution, we should create an attribute with name to and a value equal to the value of target. That's what we are doing.

wschin · 2023-01-19T23:07:27Z

-          auto copy_attr = *attr_map[attr.ref_attr_name()];
-          copy_attr.set_name(attr.name());
-          copy_n.add_attribute()->CopyFrom(copy_attr);
+  void replaceAttrParams(NodeProto& n, std::unordered_map<std::string, const AttributeProto*> attr_map) {


Why is this called "replaceAttrParams"?
What does "Param" stand for? Is it an attribute in NodeProto?

See explanation above. We want to take a node like y = Cast<to:int = @target> (x) and substitute the value of target ... for example, if target value is 6, we produce a node like y = Cast<to:int = 6> (x).

Also confused with Params here. How about calling replaceAttrValues?

An ONNX function has parameters of two kinds (just like an ONNX ops): the regular parameters (tensors, etc., whose values will be known only at runtime) and attribute-parameters ... "Param" here is shorthand for "Parameter". As discussed elsewhere, I changed the name to "AttrRefs", though I think both names should be fine.

jcwchen · 2023-01-23T17:40:07Z

-          auto copy_attr = *attr_map[attr.ref_attr_name()];
-          copy_attr.set_name(attr.name());
-          copy_n.add_attribute()->CopyFrom(copy_attr);
+  void replaceAttrParams(NodeProto& n, std::unordered_map<std::string, const AttributeProto*> attr_map) {


Also confused with Params here. How about calling replaceAttrValues?

jcwchen · 2023-01-23T17:51:35Z

+        replaceAttrParams(*attr.mutable_g(), attr_map);
+      }
+      for (auto& graph : *attr.mutable_graphs())
+        replaceAttrParams(graph, attr_map);


nit:

Suggested change

replaceAttrParams(graph, attr_map);

for (auto& graph : *attr.mutable_graphs()) {

replaceAttrParams(graph, attr_map);

}

re. the name Params: I find replaceAttrValues confusing. I could change to replaceAttrRefs I suppose. The point is that an Attribute inside a function-body could contain an attribute-value or it could be an attribute-parameter of the function itself. We want to replace the references to attribute-parameters by the values.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

jcwchen

LGTM. Thanks for fixing this!

…e inference (onnx#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

…e inference (onnx#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

) * Fix attribute substitution within subgraphs during function type/shape inference (#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Handle variants of constant op in shape inference (#4824) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Handle constant op variants Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix whitespace Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add test case Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Run lintrunner Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix parser bug in handling non-tensor types (#4863) Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix function shape inference bug (#4880) * Fix function shape inference bug Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lintrunner issues Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * bump as 1.13.1rc2 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * freeze ORT 1.13.1 to unblock failure Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * do not verify 3.11 ORT Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>

…e inference (onnx#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

* Remove operators under development from the documentation (#4753) * Remove operators under development from the documentation Signed-off-by: xadupre <xadupre@microsoft.com> * type Signed-off-by: xadupre <xadupre@microsoft.com> * infer other opset to document Signed-off-by: xadupre <xadupre@microsoft.com> * automate last opset in documentation Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Remove unused imports from code examples (#4767) Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Add missing f-string for DeprecatedWarningDict in mapping.py (#4707) * Add missing f-string for DeprecatedWarningDict in mapping.py Signed-off-by: jcwchen <jacky82226@gmail.com> * future release instead of next Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary + Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix reference implementation for ArgMin, ArgMax, Reduce* (#4710) * Fix reference implementation for ArgMin Signed-off-by: xadupre <xadupre@microsoft.com> * fix unit test Signed-off-by: xadupre <xadupre@microsoft.com> * fix one unit test in the backend Signed-off-by: xadupre <xadupre@microsoft.com> * fix method name Signed-off-by: xadupre <xadupre@microsoft.com> * fix minor bugs Signed-off-by: xadupre <xadupre@microsoft.com> * fix where Signed-off-by: xadupre <xadupre@microsoft.com> * improve error message Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix type issue Signed-off-by: xadupre <xadupre@microsoft.com> * fix recursive new ops Signed-off-by: xadupre <xadupre@microsoft.com> * add a unit test for check that new_ops is propagated through subgraphs Signed-off-by: xadupre <xadupre@microsoft.com> * remove one print used to debug Signed-off-by: xadupre <xadupre@microsoft.com> * fixes attributes in nested subgraph Signed-off-by: xadupre <xadupre@microsoft.com> * fix sequence map Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix conversion of default value into arrays Signed-off-by: xadupre <xadupre@microsoft.com> * improve code for reference Constant Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused code Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * mypy Signed-off-by: xadupre <xadupre@microsoft.com> * fix lint Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * fix col2im test data (#4769) Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Add reference implementation for domain ai.onnx.ml (#4714) * first operator ml Signed-off-by: xadupre <xadupre@microsoft.com> * rename file Signed-off-by: xadupre <xadupre@microsoft.com> * add missing import Signed-off-by: xadupre <xadupre@microsoft.com> * skip test if ONNX_ML is false Signed-off-by: xadupre <xadupre@microsoft.com> * add binarizer Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * add normalizer ... Signed-off-by: xadupre <xadupre@microsoft.com> * add label encoder Signed-off-by: xadupre <xadupre@microsoft.com> * add dict vectorizer Signed-off-by: xadupre <xadupre@microsoft.com> * add one hot encoder Signed-off-by: xadupre <xadupre@microsoft.com> * add linear models Signed-off-by: xadupre <xadupre@microsoft.com> * add tree ensemble regressor Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix missing values Signed-off-by: xadupre <xadupre@microsoft.com> * add svm regressor Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * add TreeEnsembleClassifier Signed-off-by: xadupre <xadupre@microsoft.com> * svm classifier Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * isort Signed-off-by: xadupre <xadupre@microsoft.com> * fix precision for one test on MacOS Signed-off-by: xadupre <xadupre@microsoft.com> * Finalize implementation of SVC Signed-off-by: xadupre <xadupre@microsoft.com> * add test for SVMClassifier + linear Signed-off-by: xadupre <xadupre@microsoft.com> * fix one class implementation Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused nan Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * make pages.yml only automatically trigger (#4765) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Fix types deprecated in `numpy==1.24` (#4721) * Update deprecated nptypes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Update bernoulli test files Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix Bernoulli tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Apply CR comments Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix test files Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Swap colors on documentation (#4773) Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Download test data (#4741) * 4390: Enable ONNX Hub to download test_data_set from ONNX Model Zoo Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * 4390: Enable ONNX Hub to download test_data_set from ONNX Model Zoo Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Fixed typo and changed function name to download_model_with_test_data Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data, resolved style issues Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data,resolved style issues Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Changed string formatting to f-string Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with test_data. Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Update onnx/test/hub_test.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Updated hub.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Update hub.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Make reference implementation of conv.py 30% faster (#4737) * Make reference implementation of conv.py 30% faster Signed-off-by: xadupre <xadupre@microsoft.com> * fix variable name Signed-off-by: xadupre <xadupre@microsoft.com> * change precision for two backend tests Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Fix missing page for ai.onnx.ml domain (#4776) * Fix missing page for ai.onnx.ml domain Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused code Signed-off-by: xadupre <xadupre@microsoft.com> * simplify code Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Use developing version number in the main branch (#4772) * use developing version number in the main branch Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * future onnx Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Rename attribute's subgraph in onnx.compose.add_prefix_graph (#4718) * add recursively rename attribute's subgraph Signed-off-by: jcwchen <jacky82226@gmail.com> * add None map Signed-off-by: jcwchen <jacky82226@gmail.com> * black Signed-off-by: jcwchen <jacky82226@gmail.com> * add a test Signed-off-by: jcwchen <jacky82226@gmail.com> * remove rename_attribute_graph Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Add missing class Split_18 in reference implementation (#4743) * Add missing class Split_18 in reference implementation Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused variable Signed-off-by: xadupre <xadupre@microsoft.com> * add one more test Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * remove deprecated lgtm.yml (#4794) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Change assert statements to raise statements (#4760) * Change assert statements to raise statements Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Add a section on ReferenceEvaluator in the tutorial (#4752) * Add ReferenceEvaluator to the tutorial Signed-off-by: xadupre <xadupre@microsoft.com> * fix compilation issues Signed-off-by: xadupre <xadupre@microsoft.com> * changes after first review Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Add attribute type in documentation (#4748) * add attribute type Signed-off-by: xadupre <xadupre@microsoft.com> * remove duplicated key Signed-off-by: xadupre <xadupre@microsoft.com> * fix value Signed-off-by: xadupre <xadupre@microsoft.com> * add quote around default string Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Improve documentation rendering (#4747) * update documentation Signed-off-by: xadupre <xadupre@microsoft.com> * update md Signed-off-by: xadupre <xadupre@microsoft.com> * revert TestCoverage.md Signed-off-by: xadupre <xadupre@microsoft.com> * revert Signed-off-by: xadupre <xadupre@microsoft.com> * add eol Signed-off-by: xadupre <xadupre@microsoft.com> * improve from Pad to Xor Signed-off-by: xadupre <xadupre@microsoft.com> * remove extra backtick Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Fix grammar in concepts.rst (#4758) Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Remove operators under development from the documentation (#4753) * Remove operators under development from the documentation Signed-off-by: xadupre <xadupre@microsoft.com> * type Signed-off-by: xadupre <xadupre@microsoft.com> * infer other opset to document Signed-off-by: xadupre <xadupre@microsoft.com> * automate last opset in documentation Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Remove unused imports from code examples (#4767) Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Add missing f-string for DeprecatedWarningDict in mapping.py (#4707) * Add missing f-string for DeprecatedWarningDict in mapping.py Signed-off-by: jcwchen <jacky82226@gmail.com> * future release instead of next Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary + Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Fix reference implementation for ArgMin, ArgMax, Reduce* (#4710) * Fix reference implementation for ArgMin Signed-off-by: xadupre <xadupre@microsoft.com> * fix unit test Signed-off-by: xadupre <xadupre@microsoft.com> * fix one unit test in the backend Signed-off-by: xadupre <xadupre@microsoft.com> * fix method name Signed-off-by: xadupre <xadupre@microsoft.com> * fix minor bugs Signed-off-by: xadupre <xadupre@microsoft.com> * fix where Signed-off-by: xadupre <xadupre@microsoft.com> * improve error message Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix type issue Signed-off-by: xadupre <xadupre@microsoft.com> * fix recursive new ops Signed-off-by: xadupre <xadupre@microsoft.com> * add a unit test for check that new_ops is propagated through subgraphs Signed-off-by: xadupre <xadupre@microsoft.com> * remove one print used to debug Signed-off-by: xadupre <xadupre@microsoft.com> * fixes attributes in nested subgraph Signed-off-by: xadupre <xadupre@microsoft.com> * fix sequence map Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix conversion of default value into arrays Signed-off-by: xadupre <xadupre@microsoft.com> * improve code for reference Constant Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused code Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * mypy Signed-off-by: xadupre <xadupre@microsoft.com> * fix lint Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * fix col2im test data (#4769) Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Add reference implementation for domain ai.onnx.ml (#4714) * first operator ml Signed-off-by: xadupre <xadupre@microsoft.com> * rename file Signed-off-by: xadupre <xadupre@microsoft.com> * add missing import Signed-off-by: xadupre <xadupre@microsoft.com> * skip test if ONNX_ML is false Signed-off-by: xadupre <xadupre@microsoft.com> * add binarizer Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * add normalizer ... Signed-off-by: xadupre <xadupre@microsoft.com> * add label encoder Signed-off-by: xadupre <xadupre@microsoft.com> * add dict vectorizer Signed-off-by: xadupre <xadupre@microsoft.com> * add one hot encoder Signed-off-by: xadupre <xadupre@microsoft.com> * add linear models Signed-off-by: xadupre <xadupre@microsoft.com> * add tree ensemble regressor Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix missing values Signed-off-by: xadupre <xadupre@microsoft.com> * add svm regressor Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * add TreeEnsembleClassifier Signed-off-by: xadupre <xadupre@microsoft.com> * svm classifier Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * isort Signed-off-by: xadupre <xadupre@microsoft.com> * fix precision for one test on MacOS Signed-off-by: xadupre <xadupre@microsoft.com> * Finalize implementation of SVC Signed-off-by: xadupre <xadupre@microsoft.com> * add test for SVMClassifier + linear Signed-off-by: xadupre <xadupre@microsoft.com> * fix one class implementation Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused nan Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * make pages.yml only automatically trigger (#4765) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Fix types deprecated in `numpy==1.24` (#4721) * Update deprecated nptypes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Update bernoulli test files Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix Bernoulli tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Apply CR comments Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix test files Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Swap colors on documentation (#4773) Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Download test data (#4741) * 4390: Enable ONNX Hub to download test_data_set from ONNX Model Zoo Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * 4390: Enable ONNX Hub to download test_data_set from ONNX Model Zoo Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Fixed typo and changed function name to download_model_with_test_data Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data, resolved style issues Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with_test_data,resolved style issues Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Changed string formatting to f-string Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Added test for download_model_with test_data. Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Update onnx/test/hub_test.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Updated hub.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> * Update hub.py Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Make reference implementation of conv.py 30% faster (#4737) * Make reference implementation of conv.py 30% faster Signed-off-by: xadupre <xadupre@microsoft.com> * fix variable name Signed-off-by: xadupre <xadupre@microsoft.com> * change precision for two backend tests Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Updated error messages Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Updated error messages Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Use fstring in error messages Signed-off-by: Mike Essenmacher <essen@us.ibm.com> * Change ValueError to TypeError on raise Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: Aadith Warrier <warrieraadith@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Armen Gabrielyan <armengabrielyan16@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: Przemyslaw Wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: aadith-warrier <69920978+aadith-warrier@users.noreply.github.com> * Enable pylint for onnx (#4763) * Disable pylint too-many checks (#2) Signed-off-by: Justin Chu <justinchu@microsoft.com> * Do not display on drafts to make reviewing easier Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix pages Changes.md (#4801) * fix BatchNormalization documentation Signed-off-by: xadupre <xadupre@microsoft.com> * update documentation Signed-off-by: xadupre <xadupre@microsoft.com> * remove one more tag Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: xadupre <xadupre@microsoft.com> * Fix attribute substitution within subgraphs during function type/shape inference (#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * fix version_conversion error of Pad-2 to Pad-11 caused by missing value attribu… (#4795) * fix version_conversion error of Pad-2 caused by missing value attribute which is not mandatory Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * add version_converter adapter test for pad_10_11 Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * add version_conveter test_case for Pad which has value attribute Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * match style Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * Fix typo in documentation (#4806) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix typo in documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix import submodules (#4803) * Fix import submodules Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update doc Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix DFT documentation typo (#4807) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix DFT documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Expose check_function in Python API (#4720) * Expose check_function in Python API Signed-off-by: jcwchen <jacky82226@gmail.com> * add a test and doc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * correct underline number Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * fix incorrect member for checker API (#4817) Signed-off-by: jcwchen <jacky82226@gmail.com> Signed-off-by: jcwchen <jacky82226@gmail.com> * Fix cast to string in reference implementation (#4814) * Fix cast to string in reference implementation Signed-off-by: jbachurski <kbachurski@gmail.com> * Add unit tests for string cast Signed-off-by: jbachurski <kbachurski@gmail.com> * Apply linter Signed-off-by: jbachurski <kbachurski@gmail.com> Signed-off-by: jbachurski <kbachurski@gmail.com> * Implement shape inference for Compress (#4812) Signed-off-by: jbachurski <kbachurski@gmail.com> Signed-off-by: jbachurski <kbachurski@gmail.com> Co-authored-by: daquexian <daquexian566@gmail.com> * Implement type and shape inference for OneHotEncoder (#4813) * Implement type and shape inference for OneHotEncoder Signed-off-by: jbachurski <kbachurski@gmail.com> * Remove redundant type ignore Signed-off-by: jbachurski <kbachurski@gmail.com> * Mark test for ONNX_ML only Signed-off-by: jbachurski <kbachurski@gmail.com> * Use skipUnless ONNX_ML in ML type inference tests Signed-off-by: jbachurski <kbachurski@gmail.com> --------- Signed-off-by: jbachurski <kbachurski@gmail.com> * add import-and-import-from in codeql's config (#4808) Signed-off-by: jcwchen <jacky82226@gmail.com> * Update governance to deal with steering committee vacancy (#4811) As discussed in Steering Committe, goal is to avoid costly and time-consuming mid-term election when dealing with a resignation since there is an annual election. Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> Co-authored-by: Ke Zhang <linkerzhang@yeah.net> Co-authored-by: G. Ramalingam <grama@microsoft.com> * improve README [add a) roadmap, b) community meeting] (#4810) * add a) roadmap, b) community meeting Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * minor revision Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * minor grammer fix Signed-off-by: Andreas Fehlner <fehlner@arcor.de> --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Add parameterized as a dev dependency (#4577) * Patch 2 (#3) Signed-off-by: Justin Chu <justinchu@microsoft.com> * fix Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix test Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> * clean up governance file (#4788) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Unskip a backend test in the list supported by the reference implementation (#4832) Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Move a duplicated snippet of code in one place in reference implementation (#4800) * remove unnecessary code in reference implementation Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused imports Signed-off-by: xadupre <xadupre@microsoft.com> * factorize code Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * refactoring Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix annotation Signed-off-by: xadupre <xadupre@microsoft.com> * Update onnx/reference/ops/_helpers.py Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * remove annotation due to python 3.7 bug Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> * Add one backend test mode==max of RoiAlign + ReferenceEvaluator (#4770) * Add one unit test to check mode==max for RoiAlign Signed-off-by: xadupre <xadupre@microsoft.com> * add test coverage for mode max Signed-off-by: xadupre <xadupre@microsoft.com> * add test case in backend Signed-off-by: xadupre <xadupre@microsoft.com> * fix roi onnx model Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> * Fix typo in mapping.rst (#4838) correspondance -> correspondence Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com> * update CI pipeline badges to include name of pipeline platform (#4840) Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Fix linked parameters in reference implementation for Concat (#4797) Signed-off-by: xadupre <xadupre@microsoft.com> * Fix OptionalHasElement in reference implementation (#4835) * Fix optional values in reference implementation Signed-off-by: xadupre <xadupre@microsoft.com> * lint + raise an exception Signed-off-by: xadupre <xadupre@microsoft.com> * address PR comments Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Handle variants of constant op in shape inference (#4824) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Handle constant op variants Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix whitespace Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add test case Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Run lintrunner Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * add lppool test cases (#4761) * Clarify SplitToSequence documentation (#4847) Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix type and shape issue for the reference implementation (#4839) * fix elu output type Signed-off-by: xadupre <xadupre@microsoft.com> * fix types and shapes for many operators Signed-off-by: xadupre <xadupre@microsoft.com> * fix other potential type issues Signed-off-by: xadupre <xadupre@microsoft.com> * remove comments Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> * fix wrong example of Gather-11/Gather-1 documentation (#4827) * fix wrong example of Gather-11/Gather-1 documentation Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * fix wrong explnation of Gather-11 operator's behavior Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * rebuild docs Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> --------- Signed-off-by: Tee Jung <tee.ty.jung@openedges.com> * Update Linux-CI.yml (#4852) Ubuntu-18.04 is deprecated Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Update URL for real models from ONNX Runtime (#4865) * Update URL for real models from ONNX Runtime Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * update missing BASE_URL Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * last / :( Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix python setup.py install failure in weekly pipeline (#4858) * fix weekly pipeline Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add back testing Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix linked_attributes in reference implementation of ReduceSum (#4856) * Fix issue #4850 Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix empty shape Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> * Update docs to reflect CI and lint changes (#4848) * Update docs to reflect CI and lint changes Signed-off-by: Justin Chu <justinchu@microsoft.com> * format readme Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix parser bug in handling non-tensor types (#4863) Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix SplitToSequence reference implementation (#4831) * Fix SplitToSequence reference implementation Signed-off-by: xadupre <xadupre@microsoft.com> * fix implementation of SplitToSequence Signed-off-by: xadupre <xadupre@microsoft.com> * add one backend test Signed-off-by: xadupre <xadupre@microsoft.com> * add backend test for SplitToSequence Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused import Signed-off-by: xadupre <xadupre@microsoft.com> * update test coverage Signed-off-by: xadupre <xadupre@microsoft.com> * input with no dimension Signed-off-by: xadupre <xadupre@microsoft.com> * refactoring Signed-off-by: xadupre <xadupre@microsoft.com> * test coverage Signed-off-by: xadupre <xadupre@microsoft.com> * spelling Signed-off-by: xadupre <xadupre@microsoft.com> * remove length Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * remove unused condition Signed-off-by: xadupre <xadupre@microsoft.com> * annotation, keepdims Signed-off-by: xadupre <xadupre@microsoft.com> * restore the dimension Signed-off-by: xadupre <xadupre@microsoft.com> * fix implementation Signed-off-by: xadupre <xadupre@microsoft.com> * fix keepdims Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> * Use mypy 1.0.0 (#4873) Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Create scorecard.yml (#4875) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Replace master references to main. Fix broken links. Hope DCO passes (#4864) Signed-off-by: Weon Yuan <wwyuan@us.ibm.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Update working-groups.md (#4853) * Update working-groups.md Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Update working-groups.md Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Update working-groups.md Signed-off-by: Andreas Fehlner <fehlner@arcor.de> --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> * Fix function shape inference bug (#4880) * Fix function shape inference bug Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lintrunner issues Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Use ruff to replace flake8 and plugins (#4851) * Enforce pep8 naming Signed-off-by: Justin Chu <justinchu@microsoft.com> * Use ruff Signed-off-by: Justin Chu <justinchu@microsoft.com> * update Signed-off-by: Justin Chu <justinchu@microsoft.com> * Unused imports Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix all Signed-off-by: Justin Chu <justinchu@microsoft.com> * Format Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update docs Signed-off-by: Justin Chu <justinchu@microsoft.com> * Simplify optional lint Signed-off-by: Justin Chu <justinchu@microsoft.com> * concurrency Signed-off-by: Justin Chu <justinchu@microsoft.com> * update test class name Signed-off-by: Justin Chu <justinchu@microsoft.com> * doc Signed-off-by: Justin Chu <justinchu@microsoft.com> * naming fix Signed-off-by: Justin Chu <justinchu@microsoft.com> * ruff version Signed-off-by: Justin Chu <justinchu@microsoft.com> * netdrawer Signed-off-by: Justin Chu <justinchu@microsoft.com> * fix format Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> * Dependabot version updates (#4893) Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Update README.md (#4903) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Justinchu/ruff noqa 2 (#4) (#4895) --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Temporary Mac release pipeline fix for onnxruntime 1.14.0 (#4896) * Enable testing with ORT and Python 3.11 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * revert about Python 3.11 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Update pybind11 for inclusive terminology (#4889) Signed-off-by: Mike Essenmacher <essen@us.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> * Pad-19: Add 'wrap' mode (#4793) * add wrap mode to Pad Signed-off-by: Yuan Yao <yuanyao@nvidia.com> * fix lint Signed-off-by: Yuan Yao <yuanyao@nvidia.com> * fix lint2 Signed-off-by: Yuan Yao <yuanyao@nvidia.com> * refactor opsets 18,19 using common doc generator Signed-off-by: Yuan Yao <yuanyao@nvidia.com> --------- Signed-off-by: Yuan Yao <yuanyao@nvidia.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Update action workflows to set default permission to read (#4904) * Update lint.yaml set top-level default permissions as security best practice Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update codeql.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update stale.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update win_no_exception_ci.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update weekly_mac_ci.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update release_win.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update release_linux_aarch64.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> * Update release_linux_x86_64.yml Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> --------- Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Add AveragePool-19 - add `dilations` attribute (#4790) * Initial commit Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor changes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix docs Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix linter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Update changelog Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix failing tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Simplify reference backend tests Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add dilations test case Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Update docs Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix data type Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Fix linter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor change Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Apply CR Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> --------- Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Use randint instead of randn to prevent undefined cast (float to uint) (#4804) * use randint instead of randn to prevent undefined cast float to uint Signed-off-by: jcwchen <jacky82226@gmail.com> * use unsigned integer to cover more cases Signed-off-by: jcwchen <jacky82226@gmail.com> * introduce create_random_int_input_for_cast Signed-off-by: jcwchen <jacky82226@gmail.com> * improve by reviews Signed-off-by: jcwchen <jacky82226@gmail.com> * set correct boundary Signed-off-by: jcwchen <jacky82226@gmail.com> * added for int8, int16, int32, int64 Signed-off-by: jcwchen <jacky82226@gmail.com> * fix bug test case Signed-off-by: jcwchen <jacky82226@gmail.com> --------- Signed-off-by: jcwchen <jacky82226@gmail.com> * [CI] Compile with UBSan in CI and fix ParseData nullptr issue (#4823) * [CI]: Compile with UBSan and ASan by clang Signed-off-by: jcwchen <jacky82226@gmail.com> * export correctly Signed-off-by: jcwchen <jacky82226@gmail.com> * put CXX, C in CMAKE_ARGS Signed-off-by: jcwchen <jacky82226@gmail.com> * -fsanitize=memory -fPIE -pie Signed-off-by: jcwchen <jacky82226@gmail.com> * -fsanitize=undefined,address -fno-sanitize-recover=undefined,memory Signed-off-by: jcwchen <jacky82226@gmail.com> * try Signed-off-by: jcwchen <jacky82226@gmail.com> * try MSVC instead Signed-off-by: jcwchen <jacky82226@gmail.com> * remove ; Signed-off-by: jcwchen <jacky82226@gmail.com> * /fsanitize=address /fsanitize=undefined /fsanitize=memory Signed-off-by: jcwchen <jacky82226@gmail.com> * set DEBUG=1 Signed-off-by: jcwchen <jacky82226@gmail.com> * test it on Linux Signed-off-by: jcwchen <jacky82226@gmail.com> * remove memory Signed-off-by: jcwchen <jacky82226@gmail.com> * enable alignment Signed-off-by: jcwchen <jacky82226@gmail.com> * no-sanitize-recover=all Signed-off-by: jcwchen <jacky82226@gmail.com> * find / -name "libasan.so" Signed-off-by: jcwchen <jacky82226@gmail.com> * LD_PRELOAD Signed-off-by: jcwchen <jacky82226@gmail.com> * undefined only Signed-off-by: jcwchen <jacky82226@gmail.com> * remove ld_preload Signed-off-by: jcwchen <jacky82226@gmail.com> * pytest -sv Signed-off-by: jcwchen <jacky82226@gmail.com> * debug parsedata Signed-off-by: jcwchen <jacky82226@gmail.com> * test Signed-off-by: jcwchen <jacky82226@gmail.com> * test Signed-off-by: jcwchen <jacky82226@gmail.com> * test Signed-off-by: jcwchen <jacky82226@gmail.com> * nullptr Signed-off-by: jcwchen <jacky82226@gmail.com> * test Signed-off-by: jcwchen <jacky82226@gmail.com> * test Signed-off-by: jcwchen <jacky82226@gmail.com> * != 0 Signed-off-by: jcwchen <jacky82226@gmail.com> * invalid raw_data Signed-off-by: jcwchen <jacky82226@gmail.com> * raw_data.empty() Signed-off-by: jcwchen <jacky82226@gmail.com> * fix lint Signed-off-by: jcwchen <jacky82226@gmail.com> --------- Signed-off-by: jcwchen <jacky82226@gmail.com> * Update description regarding Ubuntu in README.md (#4867) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Pin actions to a full length commit SHA (#4894) * Pin actions to a full length commit SHA Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * add release yml Signed-off-by: Andreas Fehlner <fehlner@arcor.de> --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * fix OptionalGetElement shape inference when input is a tensor (#4905) * Update dependabot.yml (#4901) Show version updates for github actions (documentation here... https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#configuration-options-for-the-dependabotyml-file) => Does relate to https://github.com/onnx/onnx/pull/4894 (fixating the used there.... and get's update if there is a new version available) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Extend Equal operator to support string type (#4828) * Extend Equal operator to support string type Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Version converter Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Generate documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Regenerate test data Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add test cases Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Lint and missing file Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Generate docs Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Move onnx-weekly package from TestPyPI to PyPI (#4897) * Move onnx-weekly from TestPyPI to PyPI Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * still upload onnx-weekly to TestPyPI until next ONNX release Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * read permission + pinned github action versions (security best practice according to openssf) (#4910) * security best practice according to openssf Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Update release_linux_x86_64.yml Signed-off-by: Andreas Fehlner <fehlner@arcor.de> --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Update README.md (#4883) Signed-off-by: Andreas Fehlner <fehlner@arcor.de> * Bump docker/setup-qemu-action from 1.2.0 to 2.1.0 (#4916) Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1.2.0 to 2.1.0. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](https://github.com/docker/setup-qemu-action/compare/27d0a4f181a40b142cce983c5393082c365d1480...e81a89b1732b9c48d79cd809d8d81d79c4647a18) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Bump microsoft/setup-msbuild from 1.1.3 to 1.3.1 (#4918) Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.1.3 to 1.3.1. - [Release notes](https://github.com/microsoft/setup-msbuild/releases) - [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md) - [Commits](https://github.com/microsoft/setup-msbuild/compare/34cfbaee7f672c76950673338facd8a73f637506...1ff57057b5cfdc39105cd07a01d78e9b0ea0c14c) --- updated-dependencies: - dependency-name: microsoft/setup-msbuild dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 1.0.0 to 3.1.2 (#4922) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1.0.0 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v1...0b7f8abb1508181956e8e162db84b466c27e18ce) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (#4914) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.1.2. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](https://github.com/ossf/scorecard-action/compare/99c53751e09b9529366343771cc321ec74e9bd3d...e38b1902ae4f44df626f11ba0734b14fb91f8f86) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Bump actions/stale from 5.2.0 to 7.0.0 (#4917) Bumps [actions/stale](https://github.com/actions/stale) from 5.2.0 to 7.0.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/stale/compare/99b6c709598e2b0d0841cd037aaf1ba07a4410bd...6f05e4244c9a0b2ed3401882b05d701dd0a7289b) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/configure-pages from 2.1.3 to 3.0.4 (#4925) Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 2.1.3 to 3.0.4. - [Release notes](https://github.com/actions/configure-pages/releases) - [Commits](https://github.com/actions/configure-pages/compare/c5a3e1159e0cbdf0845eb8811bd39e39fc3099c2...fc89b04e7d263ef510d9e77d3a1d088fb2688522) --- updated-dependencies: - dependency-name: actions/configure-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove non-required pyzmq due to different license (#4926) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Use the furo theme (#4923) * Theme Signed-off-by: Justin Chu <justinchu@microsoft.com> * requirements options conf Signed-off-by: Justin Chu <justinchu@microsoft.com> * Remove tocs as furo does not need them Signed-off-by: Justin Chu <justinchu@microsoft.com> * logo Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Disallow and fix relative imports (#4924) * Disallow relative imports Signed-off-by: Justin Chu <justinchu@microsoft.com> * bump ruff version Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix Signed-off-by: Justin Chu <justinchu@microsoft.com> * fix ruff version Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix format Signed-off-by: Justin Chu <justinchu@microsoft.com> * Fix mypy Signed-off-by: Justin Chu <justinchu@microsoft.com> * format Signed-off-by: Justin Chu <justinchu@microsoft.com> * black Signed-off-by: Justin Chu <justinchu@microsoft.com> * doc Signed-off-by: Justin Chu <justinchu@microsoft.com> * docs again Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> * [Non functional changes] Added links to the SIG and Working group pages to reduce redundancy (#4906) * added compilers sig as well as a link to the SIG pages Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * responded to comments about reducing redundancy between onnx repo Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> --------- Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * Add Resize-19: half_pixel_symmetric (#4862) * Add Resize-19: half_pixel_symmetric Signed-off-by: Joaquin Anton <janton@nvidia.com> * Code review fixes Signed-off-by: Joaquin Anton <janton@nvidia.com> * Resize-19 adapter Signed-off-by: Joaquin Anton <janton@nvidia.com> * Lint fix Signed-off-by: Joaquin Anton <janton@nvidia.com> --------- Signed-off-by: Joaquin Anton <janton@nvidia.com> * after ONNX 1.13.1 release (#4932) * Set default CheckerContext for check_function properly (#4928) * set default Context for check_function properly Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use default optional None Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use find_min_ir_version_for Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add ignore_unknown Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Fix STFT output shape (#4920) * fix stft output shape Signed-off-by: Justin Stoecker <justoeck@microsoft.com> * clean up curious double conditional Signed-off-by: Justin Stoecker <justoeck@microsoft.com> --------- Signed-off-by: Justin Stoecker <justoeck@microsoft.com> * Autoformat with ruff SIM rules (#4935) * Autoformat with ruff SIM rules Signed-off-by: Justin Chu <justinchu@microsoft.com> * diff Signed-off-by: Justin Chu <justinchu@microsoft.com> * rules Signed-off-by: Justin Chu <justinchu@microsoft.com> * rules Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Sphinx type name rendering (#4938) Signed-off-by: Justin Chu <justinchu@microsoft.com> * Use light local onnx file instead of heavy remote files (#4861) * add data file Signed-off-by: xadupre <xadupre@microsoft.com> * use local files Signed-off-by: xadupre <xadupre@microsoft.com> * avoid real tests Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * use local files Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * remove eol Signed-off-by: xadupre <xadupre@microsoft.com> * add function replace_initializer_by_constant_of_shape Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * support constant Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * support functions Signed-off-by: xadupre <xadupre@microsoft.com> * fix support of graph Signed-off-by: xadupre <xadupre@microsoft.com> * documentation Signed-off-by: xadupre <xadupre@microsoft.com> * add a test to run the backend for ReferenceEvaluator Signed-off-by: xadupre <xadupre@microsoft.com> * finalize backend test Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * exception messahge Signed-off-by: xadupre <xadupre@microsoft.com> * List[NodeProto] Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * exclude test on Windows Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix spelling Signed-off-by: xadupre <xadupre@microsoft.com> * documentation Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> * Bump github/codeql-action from 2.2.4 to 2.2.5 (#4947) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.4 to 2.2.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/v2.2.4...32dc499307d133bb5085bae78498c0ac2cf762d5) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add method to type-check a function (#4912) * Expose function type checker Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Expose inference-check for function Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add test case Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Move from checker to inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add attribute test Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * One more test Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * fix import Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Unused parameters Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Formatting changes Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Formatting changes Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Vector reserve and unused parameters Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Omit unused imports Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * replace MIT with Apache-2.0 (#4943) Signed-off-by: andife <fehlner@arcor.de> * remove 3 unnecessary files (#4953) Signed-off-by: xadupre <xadupre@microsoft.com> * Make LRN reference implementation 50x faster (#4954) * Make LRN reference implementation 50x faster Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> * Fix Windows x86 pipeline failure: handle NumPy behavior in reference (#4955) * Fix Windows x86 pipeline failure: handle NumPy behavior in onnx.reference Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use astype(np.int64) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add run release CIs to cover more pipelines for testing (#4948) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * Apply ORT 1.14.1 to resolve compatibility issue on Mac (#4950) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> * proto to support attributes with default values (#4911) * fix something introduced with formatting (#4967) * Update function default-attribute documentation (#4965) Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Clarify reduction op inputs can be rank-0 tensors (scalars) (#4963) * Update reduce op doc Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Generate documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Update documentation of optional arguments (#4970) * Update documentation of optional arguments Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Update formatting Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix softplus function definition (#4979) * Fix softplus function definition Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Regenerate documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add auto-generated tests Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add comments to pyproject.toml to explain how to configure linters (#4978) * Update pyproject.toml Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> * Update pyproject.toml Signed-off-by: Justin Chu <justinchu@microsoft.com> --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Bump actions/deploy-pages from 1.2.4 to 1.2.5 (#4985) Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 1.2.4 to 1.2.5. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](https://github.com/actions/deploy-pages/compare/0243b6c10d06cb8e95ed8ee471231877621202c0...497da40f5225e762159b457c9ae5d6f75a136f5c) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> * Bump github/codeql-action from 2.2.5 to 2.2.6 (#4984) * Bump github/codeql-action from 2.2.5 to 2.2.6 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.5 to 2.2.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/32dc499307d133bb5085bae78498c0ac2cf762d5...16964e90ba004cdf0cd845b866b5df21038b7723) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update .github/workflows/scorecard.yml Signe…

gramalingam added 2 commits January 19, 2023 14:28

Fix attribute substitution within subgraphs in function inference

fc29726

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Delete commented out dead code

3eb21ca

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

gramalingam requested a review from a team as a code owner January 19, 2023 22:36

github-advanced-security AI found potential problems Jan 19, 2023

View reviewed changes

Comment thread onnx/test/model_inference_test.py Fixed

Comment thread onnx/test/model_inference_test.py Fixed

Comment thread onnx/test/model_inference_test.py Fixed

wschin reviewed Jan 19, 2023

View reviewed changes

titaiwangms mentioned this pull request Jan 20, 2023

[ONNX] atenlib evaluator pytorch/pytorch#92194

Closed

xadupre reviewed Jan 20, 2023

View reviewed changes

Comment thread onnx/test/model_inference_test.py

titaiwangms mentioned this pull request Jan 20, 2023

[ONNX] onnxscript w/ atenlib pytorch/pytorch#92717

Merged

jcwchen added the module: shape inference Issues related to shape inference label Jan 23, 2023

jcwchen reviewed Jan 23, 2023

View reviewed changes

Address PR feedback

46c629f

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

github-advanced-security AI found potential problems Jan 23, 2023

View reviewed changes

Comment thread onnx/test/model_inference_test.py Fixed

gramalingam added 3 commits January 23, 2023 13:13

Fix lint issue

f841733

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Merge branch 'main' into main

7257ebd

Merge branch 'main' into main

7bb1a0b

jcwchen approved these changes Jan 24, 2023

View reviewed changes

gramalingam merged commit 538576f into onnx:main Jan 24, 2023

gramalingam added this to the 1.13.1 milestone Feb 9, 2023

jcwchen mentioned this pull request Feb 10, 2023

[1.13.1rc2] More cherry picks for fixing function shape inference #4886

Merged

Conversation

gramalingam commented Jan 19, 2023

Description

Motivation and Context

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcwchen Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jcwchen Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jcwchen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jcwchen Jan 23, 2023 •

edited

Loading

jcwchen Jan 23, 2023 •

edited

Loading