MAINT: Add additional information to missing scalar AttributeError#22971
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Jan 9, 2023
Merged
MAINT: Add additional information to missing scalar AttributeError#22971charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
This is a followup on numpygh-22607 which removed them. Since it appears some users missed the DeprecationWarning entirely, it may help them to include the old information as an attribute error. An example is: ``` In [1]: np.int AttributeError: module 'numpy' has no attribute 'int'. `np.int` was a deprecated alias for the builtin `int`. To avoid this error in existing code, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations ``` Yes, that is very verbose... your changes. Lines starting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 22947.
This is a followup on gh-22607 which removed them. Since it appears some users missed the DeprecationWarning entirely, it may help them to include the old information as an attribute error.
An example is:
Yes, that is very verbose...
your changes. Lines starting