BUG: Ensure correct behavior for rows ending in delimiter in loadtxt #22847
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Dec 21, 2022
Merged
BUG: Ensure correct behavior for rows ending in delimiter in loadtxt #22847charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
…umpy#22836) If a row ends in a delimiter, `add_fields` can be called twice without any field actually being parsed. This causes issues with the field buffer setup. closes numpygh-22833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22836
If a row ends in a delimiter,
add_fieldscan be called twice without any field actually being parsed. This causes issues with the field buffer setup.Basically, I tried to be too smart, and now it needs a small fixup...
closes gh-22833