BUG, SIMD: Fix invalid value encountered in several ufuncs #22834
Merged
charris merged 8 commits intonumpy:maintenance/1.24.xfrom Dec 20, 2022
Merged
BUG, SIMD: Fix invalid value encountered in several ufuncs #22834charris merged 8 commits intonumpy:maintenance/1.24.xfrom
charris merged 8 commits intonumpy:maintenance/1.24.xfrom
Conversation
Providing non-signaling comparison intrinsics that guarantee no FP invalid exception in case of qNaN sounds great but it cost unacceptable extra intrinsics on ppc64le(VSX) and x86(SSE). Therefore, an integer definition #NPY_SIMD_CMPSIGNAL has been provided instead to differenate between SIMD extensions that support only supports signaling comparison.
Member
Author
|
@seiko2plus I suspect there is another backport needed to fix the invalid value in power error. Any idea what that is? |
Member
My editor trimmed whitespace of this line: numpy/numpy/core/tests/test_umath.py Line 1091 in 28329b2 For somehow during rebases, you bring the power test cases instead of ignoring trimming the white space.
either backport #18535 and #22737 or just removes the power test case. |
Fixes missing backports that can wait until 1.24.x.
Member
Author
|
Thanks @seiko2plus. I deleted the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22771.
closes #22461, #22772, #22797
for more clarification check the linked issues above