MAINT: Help boost::python libraries at least not crash#20618
Merged
charris merged 1 commit intonumpy:maintenance/1.21.xfrom Dec 18, 2021
Merged
MAINT: Help boost::python libraries at least not crash#20618charris merged 1 commit intonumpy:maintenance/1.21.xfrom
charris merged 1 commit intonumpy:maintenance/1.21.xfrom
Conversation
This adds an almost random "sanity check" to `PyArray_EquivTypes` for the sole purpose of allowing boost::python compiled libs to _not crash_. boost::python is buggy, it needs to be fixed. This may break them (I am unsure), because some conversions which used to work may fail here (if they worked, they only worked because random type data may have matched up correctly for our scalar types). We could error, or warn or... but I hope boost::python will just fix this soon enough and future us can just delete the whole branch. Replaces numpygh-20507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20616.
This adds an almost random "sanity check" to
PyArray_EquivTypesfor the sole purpose of allowing boost::python compiled libs to
not crash.
boost::python is buggy, it needs to be fixed. This may break them
(I am unsure), because some conversions which used to work may fail
here (if they worked, they only worked because random type data may
have matched up correctly for our scalar types).
We could error, or warn or... but I hope boost::python will just fix
this soon enough and future us can just delete the whole branch.
Replaces gh-20507