Skip to content

BLD: Verify the ability to compile C++ sources before initiating the build#20464

Merged
charris merged 2 commits intonumpy:maintenance/1.21.xfrom
charris:backport-20354
Nov 26, 2021
Merged

BLD: Verify the ability to compile C++ sources before initiating the build#20464
charris merged 2 commits intonumpy:maintenance/1.21.xfrom
charris:backport-20354

Conversation

@charris
Copy link
Member

@charris charris commented Nov 25, 2021

Backport of #20354.

related to #20335

@charris charris added 08 - Backport Used to tag backport PRs 36 - Build Build related PR labels Nov 25, 2021
@charris charris added this to the 1.21.5 release milestone Nov 25, 2021
@charris charris merged commit 1d1f044 into numpy:maintenance/1.21.x Nov 26, 2021
@charris charris deleted the backport-20354 branch November 26, 2021 01:44
charris added a commit to charris/numpy that referenced this pull request Dec 19, 2021
This reverts commit 1d1f044, reversing changes made to 157ee4f.

The backport was in error, as there is no C++ in NumPy 1.21.x. The
change caused problems with the manylinux1 compiler, which is not
C++11 compatible.
charris added a commit to charris/numpy that referenced this pull request Apr 10, 2022
This reverts commit 1d1f044, reversing changes made to 157ee4f.

The backport was in error, as there is no C++ in NumPy 1.21.x. The
change caused problems with the manylinux1 compiler, which is not
C++11 compatible.
charris added a commit that referenced this pull request Apr 11, 2022
REV: Revert pull request #20464 from charris/backport-20354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 - Backport Used to tag backport PRs 36 - Build Build related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants