MAINT: Proposal to expire three deprecated functions in numpy.lib.npyio #19615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Aug 5, 2021
Member
seberg
left a comment
There was a problem hiding this comment.
Weird that the tests actually only use genfromtext (I guess to avoid the warning...). In any case we seem to have more tests with usemask=True so looks good to me, unless anyone wants to nitpick the release notes :).
Contributor
Author
Suggestions welcome - I'm happy to expand/reorganize them! |
Member
I'll edit them all into a list when the release notes are generated. |
Member
|
Thanks Ross. |
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three functions in the
npyiomodule which are all in the main namespace that are suitable for removal according to the criteria laid out in NEP23:np.loads, deprecated in v1.15np.ndfromtxtandnp.mafromtxt, both deprecated in v1.17.This PR proposes to remove them outright, but happy to hear thoughts on the appropriate course of action.