BUG: Use whole file for encoding checks with charset_normalizer. #22887
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Dec 26, 2022
Merged
BUG: Use whole file for encoding checks with charset_normalizer. #22887charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charset_normalizer. #22887charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
…py] (numpy#22872) * BUG: Use whole file for encoding checks [f2py] * DOC: Add a code comment Co-authored-by: melissawm <melissawm@gmail.com> * TST: Add a conditional unicode f2py test * MAINT: Add chardet as a test requirement * ENH: Cleanup and switch f2py to charset_normalizer * MAINT: Remove chardet for charset_normalizer * TST: Simplify UTF-8 encoding [f2py] Co-authored-by: melissawm <melissawm@gmail.com>
charset_normalizer charset_normalizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport or #22872.
BUG: Use whole file for encoding checks [f2py]
DOC: Add a code comment
Co-authored-by: melissawm melissawm@gmail.com
TST: Add a conditional unicode f2py test
MAINT: Add chardet as a test requirement
ENH: Cleanup and switch f2py to charset_normalizer
MAINT: Remove chardet for charset_normalizer
TST: Simplify UTF-8 encoding [f2py]
Co-authored-by: melissawm melissawm@gmail.com