BUG: Fix integer overflow in in1d for mixed integer dtypes #22877#22884
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Dec 25, 2022
Merged
BUG: Fix integer overflow in in1d for mixed integer dtypes #22877#22884charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
numpy#22878) * TST: Mixed integer types for in1d * BUG: Fix mixed dtype overflows for in1d (numpy#22877) * BUG: Type conversion for integer overflow check * MAINT: Fix linting issues in in1d * MAINT: ar1 overflow check only for non-empty array * MAINT: Expand bounds of overflow check * TST: Fix integer overflow in mixed boolean test * TST: Include test for overflow on mixed dtypes * MAINT: Less conservative overflow checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22878.
TST: Mixed integer types for in1d
BUG: Fix mixed dtype overflows for in1d (BUG:
numpy.isindoes not function correctly with two arrays with different integer type #22877)BUG: Type conversion for integer overflow check
MAINT: Fix linting issues in in1d
MAINT: ar1 overflow check only for non-empty array
MAINT: Expand bounds of overflow check
TST: Fix integer overflow in mixed boolean test
TST: Include test for overflow on mixed dtypes
MAINT: Less conservative overflow checks