refactor(test): Mocha DSL for destroy & dynamic mocks.#1941
Merged
mastermatt merged 1 commit intonock:masterfrom Mar 3, 2020
Merged
refactor(test): Mocha DSL for destroy & dynamic mocks.#1941mastermatt merged 1 commit intonock:masterfrom
mastermatt merged 1 commit intonock:masterfrom
Conversation
gr2m
approved these changes
Mar 3, 2020
paulmelnikow
approved these changes
Mar 3, 2020
|
🎉 This PR is included in version 12.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
juninmd
pushed a commit
to juninmd/nock
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the one test from 'dynamic' to
test_reply_function_async.jssince it was passing the callback as a second arg, then added a few tests totest_dynamic_mock.jsto cover body and headers being optional.