Merged
Conversation
asomers
requested changes
Sep 30, 2019
Member
asomers
left a comment
There was a problem hiding this comment.
Good start, but don't forget to add a CHANGELOG.
|
|
||
| let stats = stat::stat(&mkfifoat_fifo).unwrap(); | ||
| let typ = stat::SFlag::from_bits_truncate(stats.st_mode); | ||
| assert!(typ == SFlag::S_IFIFO); |
Member
There was a problem hiding this comment.
This should be assert_eq instead, here and elsewhere.
| let typ = stat::SFlag::from_bits_truncate(stats.st_mode); | ||
| assert!(typ == SFlag::S_IFIFO); | ||
|
|
||
|
|
| assert!(typ == SFlag::S_IFIFO); | ||
|
|
||
|
|
||
| let dirfd = open(tempdir.path(), OFlag::empty(), Mode::empty()).unwrap(); |
Member
There was a problem hiding this comment.
This part should really be a separate test case.
| // mkfifoat should fail if a directory is given | ||
| assert!(mkfifoat(None, &env::temp_dir(), Mode::S_IRUSR).is_err()); | ||
|
|
||
| let tempdir = tempfile::tempdir().unwrap(); |
Member
There was a problem hiding this comment.
This part should be a separate test case.
ignore mkfifoat in OSX and andriod
Contributor
Author
bors Bot
added a commit
that referenced
this pull request
Oct 7, 2019
1133: Implement mkfifoat r=asomers a=zmlcc This adds the `mkfifoat ` function, which is part of POSIX [https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkfifoat.html](https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkfifoat.html) test cases are copied from `mkfifo` Co-authored-by: Zhang Miaolei <zmlcc@outlook.com>
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
mkfifoatfunction, which is part of POSIX https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkfifoat.htmltest cases are copied from
mkfifo