Updates to German translation#529
Merged
stevehu merged 2 commits intonetworknt:masterfrom Mar 9, 2022
rustermi:master
Merged
Conversation
The translation is understandable for all German speaking people. However, the previous file name resulted in these translations only being used for Germany (de_DE). A JVM running with Austrian German (de_AT) or simply German (de) would have resulted in the English default messages being returned.
- 'false' translation was missing - Wording has been improved for cases with zero, one or many elements - Capitalisation of words after a colon has been unified
Contributor
|
@rustermi Thanks a lot for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now have the newest version (1.0.67) running in production, I found a few things this PR fixes now:
Renamed
messages_de_DE.propertiesThe translation is understandable for all German speaking people. However, the previous file name lead to these translations only being used for Germany (
de_DE— German on German territory). A JVM running with Austrian German (de_AT) or simply German without any territory descriptor (de) resulted in the English default messages being used.Update German translations
Sorry for the inconvenience and thank you for your work.