Add TLS SNI Extension in HTTP/2 Client request.#9937
Merged
normanmaurer merged 2 commits intonetty:4.1from Jan 10, 2020
hyperxpro:4.1
Merged
Add TLS SNI Extension in HTTP/2 Client request.#9937normanmaurer merged 2 commits intonetty:4.1from hyperxpro:4.1
normanmaurer merged 2 commits intonetty:4.1from
hyperxpro:4.1
Conversation
…n in TLS Client Hello request.
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
Split Comment and Code Line
Contributor
Author
|
@normanmaurer Fixed Line Length Error. Moved comment into another line. |
Member
|
@netty-bot test this please |
Member
|
@hyperxpro can you also sign our ICLA and let me know once done: |
Contributor
Author
Done |
Member
|
@hyperxpro thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jan 10, 2020
Motivation: Since "Http2ClientInitializer" creates a new SSLContext Handler without specifying Host, Netty does not add SNI Extension in TLS Client Hello request and the request fails if the server uses SNI to establish TLS Connection. Modification: Specified Host while creating a new SSLContext Handler in "Http2ClientInitializer". Result: Netty adds SNI Extension of the Host Specified in new SSLContext Handler and sends it with TLS Client Hello request. Fixes #9815.
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
Motivation: Since "Http2ClientInitializer" creates a new SSLContext Handler without specifying Host, Netty does not add SNI Extension in TLS Client Hello request and the request fails if the server uses SNI to establish TLS Connection. Modification: Specified Host while creating a new SSLContext Handler in "Http2ClientInitializer". Result: Netty adds SNI Extension of the Host Specified in new SSLContext Handler and sends it with TLS Client Hello request. Fixes netty#9815.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TLS SNI Extension in HTTP/2 Client request.
Motivation:
Since "Http2ClientInitializer" creates a new SSLContext Handler without specifying Host, Netty does not add SNI Extension in TLS Client Hello request and the request fails if the server uses SNI to establish TLS Connection.
Modification:
Specified Host while creating a new SSLContext Handler in "Http2ClientInitializer".
Result:
Netty adds SNI Extension of the Host Specified in new SSLContext Handler and sends it with TLS Client Hello request.
Fixes #9815.