@slawekjaranowski please review

Spotted a minor bug: change recorder would always output changes, even if they did not occur in the POM that was being processed. Fixed.

This resolves #837

Added the same to UpdatePropertyMojo

And abstracted a common base for the two mojos.

Tried to resolve conflicts using GitHub 🤦

We set such parameters to false in #817

Should be here default as true?

Should be here default as true?

No. With false, it will break #582. Like I said in the first comment,

Setting it to false will speed up execution to a great extend without sacrificing accuracy in most cases. However, if the POM redefines properties used in parent POMs, dependencies bound to those properties will not be discovered, so the plugin will not redefine those properties. Therefore the default value is true.

So, it can only be treated as a speedup if one knows what they're doing. It will sometimes render the results wrong.

So, it must be true.

By the way, should I remove this?

getLog().debug( "Using Maven 2.0.10+ strategy to determine lifecycle defined plugins" );
        try
        {
            Method getLifecycles = LifecycleExecutor.class.getMethod( "getLifecycles" );
            List<Lifecycle> lifecycles = (List) getLifecycles.invoke( lifecycleExecutor, new Object[0] );
            // lookup the bindings for all the passed in phases
            return Arrays.stream( thePhases.split( "," ) )
                    .filter( StringUtils::isNotEmpty )
                    .map( phase -> getLifecycleForPhase( lifecycles, phase ) )
                    .filter( Objects::nonNull )
                    .collect( HashSet::new,
                            ( s, l ) -> s.addAll( getAllPlugins( project, l ) ),
                            Set::addAll );

Maven 2.x code should be remove, can be done in separate PR.
We use 3.2.5 as minimum.

Maven 2.x code should be remove, can be done in separate PR.
We use 3.2.5 as minimum.

I'll do that in another PR then