Skip to content

#333: aggregated reports#836

Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom
MihaStemberger:feature/333_aggregated_reports
Dec 4, 2022
Merged

#333: aggregated reports#836
slawekjaranowski merged 1 commit intomojohaus:masterfrom
MihaStemberger:feature/333_aggregated_reports

Conversation

@MihaStemberger
Copy link
Copy Markdown

Hello, here is my shot at trying to solve #333

@MihaStemberger MihaStemberger changed the title Feature/333 aggregated reports #333: aggregated reports Nov 30, 2022
@andrzejj0
Copy link
Copy Markdown
Contributor

@slachiewicz or @slawekjaranowski can you approve the flow please? Thanks!

Comment thread versions-maven-plugin/src/it-repo/dummy-aggregate-child-333.pom Outdated
Comment thread versions-maven-plugin/src/it/it-plugin-updates-aggregate-report-issue-333/pom.xml Outdated
@slawekjaranowski
Copy link
Copy Markdown
Member

For new files we use standard Apache 2.0 license headers:
https://groups.google.com/g/mojohaus-dev/c/OTg7XfiX61w

I prefer groovy scripts for verification than beanshell ... as nice to have 😄

@MihaStemberger
Copy link
Copy Markdown
Author

For new files we use standard Apache 2.0 license headers: https://groups.google.com/g/mojohaus-dev/c/OTg7XfiX61w

I prefer groovy scripts for verification than beanshell ... as nice to have smile

Added Apache 2.0 license headers to newly added *.java files, replaced beanshell verification scripts with groovy scripts

Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits

  aggregated reports
@MihaStemberger
Copy link
Copy Markdown
Author

last nits

Resolved

@slawekjaranowski slawekjaranowski linked an issue Dec 3, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Dec 3, 2022
@slawekjaranowski slawekjaranowski merged commit 112e9ee into mojohaus:master Dec 4, 2022
@MihaStemberger
Copy link
Copy Markdown
Author

I forgot to ask. Is there something to add, for added aggregate report goals to be visible under https://www.mojohaus.org/versions-maven-plugin/#reporting-goals-overview ?

@andrzejj0
Copy link
Copy Markdown
Contributor

andrzejj0 commented Dec 5, 2022

Yes, you're supposed to have edited https://github.com/mojohaus/versions-maven-plugin/blob/master/versions-maven-plugin/src/site/markdown/index.md

But I guess you can still do it in another PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aggregate reports support

3 participants