Resolves #505: getReactorModels using correct module paths when the module name includes pom.xml#805
Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom Nov 3, 2022
Conversation
Contributor
Author
|
|
8981bc0 to
a406bb2
Compare
Contributor
Author
|
Rebased. |
…en the module name includes pom.xml
a406bb2 to
ff6fe8d
Compare
|
I think there might have been a break here: |
Member
Contributor
Author
|
@rshkv thanks. Tested this with the PR, problem looks solved. |
|
Thank you for the reply guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing fancy or spectacular, just a simple bug fix for the edge case of having the module name include the pom.xml file path. In the unpatched implementation, the "/pom.xml" was treated as part of the directory name when descending down the module tree to retrieve child models... Fixed that.
Added some tests (unit test for the PomHelper method + integration test for the use case from the issue).
@slawekjaranowski please review