Pinned ByteBuddy to 1.9.10#1676
Merged
Merged
Conversation
TimvdLippe
approved these changes
Mar 26, 2019
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending green build.
The build does not seem to work correctly with 1.9.11
Codecov Report
@@ Coverage Diff @@
## release/2.x #1676 +/- ##
================================================
+ Coverage 86.59% 87.39% +0.8%
- Complexity 2442 2446 +4
================================================
Files 302 302
Lines 6325 6325
Branches 787 787
================================================
+ Hits 5477 5528 +51
+ Misses 663 603 -60
- Partials 185 194 +9
Continue to review full report at Codecov.
|
Member
Author
|
I'm going to merge this. It appears that there are consistent build failures on Java 9+ when ByteBuddy 1.9.11 is used. 1.9.10 works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that new version of BB breaks the build for Java 9+. I'm still investigating. Opening the PR for visibility - we can see if the build is happy now.