Allow STOPSIGNAL instruction in commit change#43369
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 26, 2022
Merged
Conversation
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
tianon
approved these changes
Mar 25, 2022
tonistiigi
approved these changes
Mar 25, 2022
Member
|
I was wondering recently what the future should be of this feature, or more specifically; using the This PR looks fine to merge though for now (it doesn't really dig us in too much deeper into the hack); I kicked CI again as it was failing on unrelated things. |
Member
|
All green now; let's get this merged (thanks!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add
stopsignalinvalidCommitCommandsforcommitcommand.- How I did it
docker commitcommand requestsCreateImageFromContainerfunction.moby/daemon/commit.go
Line 119 in a583434
dockerfile.BuildFromConfigfunctionmoby/daemon/commit.go
Line 149 in a583434
validCommitCommandsis used to rejected unsupported instructions indockerfile.BuildFromConfigmoby/builder/dockerfile/builder.go
Line 339 in a583434
CreateImageFromContainerfunction,mergefunction already support StopSIgnalmoby/daemon/commit.go
Line 110 in a583434
- How to verify it
Commit a new image with following command:
docker commit xxxx -c "STOPSIGNAL SIGRTMIN+3"- Description for the changelog
Allow STOPSIGNAL instruction in commit changes
- A picture of a cute animal (not mandatory but encouraged)
