Fix a leaked run error in test_pytorch_test_metrics_logged#4302
Merged
harupy merged 1 commit intomlflow:masterfrom Apr 30, 2021
Merged
Fix a leaked run error in test_pytorch_test_metrics_logged#4302harupy merged 1 commit intomlflow:masterfrom
test_pytorch_test_metrics_logged#4302harupy merged 1 commit intomlflow:masterfrom
Conversation
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
commented
Apr 29, 2021
Comment on lines
-270
to
+273
| trainer.fit(model, dm) | ||
| trainer.test() | ||
| with mlflow.start_run() as run: | ||
| trainer.fit(model, dm) | ||
| trainer.test() |
Member
Author
There was a problem hiding this comment.
This change in the pytorch-lightning repo caused the issue:
Prior to this change, Trainer.test calls Trainer.fit (which is patched and automatically creates / terminates a run). This means when on_test_end is called, an active run exists.
Now Trainer.test no longer calls Trainer.fit. This means when on_test_end is called, no active run exists and a new run will be created by mlflow.set_tag and leaked.
def on_test_end(self, trainer, pl_module):
"""
Logs accuracy and other relevant metrics on the testing end
:param trainer: pytorch lightning trainer instance
:param pl_module: pytorch lightning base module
"""
try_mlflow_log(mlflow.set_tag, "Mode", "testing")
for key, value in trainer.callback_metrics.items():
try_mlflow_log(mlflow.log_metric, key, float(value))
wamartin-aml
approved these changes
Apr 29, 2021
WeichenXu123
approved these changes
Apr 30, 2021
YQ-Wang
pushed a commit
to YQ-Wang/mlflow
that referenced
this pull request
May 29, 2021
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> Signed-off-by: Yiqing Wang <yiqing@wangemail.com>
harupy
added a commit
to wamartin-aml/mlflow
that referenced
this pull request
Jun 7, 2021
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy 17039389+harupy@users.noreply.github.com
What changes are proposed in this pull request?
Fix a leaked run error in
test_pytorch_test_metrics_logged.https://github.com/mlflow/mlflow/runs/2464693969?check_suite_focus=true#step:10:23
How is this patch tested?
Fixed test
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes