sqlite3_test.go: Move Go 1.13 test to sqlite3_go113_test.go#883
Merged
mattn merged 1 commit intomattn:masterfrom Nov 16, 2020
evanj:fix-raw
Merged
sqlite3_test.go: Move Go 1.13 test to sqlite3_go113_test.go#883mattn merged 1 commit intomattn:masterfrom evanj:fix-raw
mattn merged 1 commit intomattn:masterfrom
evanj:fix-raw
Conversation
Commit 4f7abea added a test that uses Conn.Raw, which was added in Go >= 1.13. The go-sqlite3 project runs tests with Go >= 1.11. Remove the test from sqlite3_test.go, so it only runs with the correct versions of Go. Instead of adding a new test, modify the existing test that already uses Conn.Raw() to check the type of driverConn.
Owner
|
Thank you! I'll merge after CI pass. |
Contributor
Author
|
The Windows failure is: I hope I did this correctly this time! 😄 thank you! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 4f7abea added a test that uses Conn.Raw, which was added in
Go >= 1.13. The go-sqlite3 project runs tests with Go >= 1.11. Remove
the test from sqlite3_test.go, so it only runs with the correct
versions of Go.
Instead of adding a new test, modify the existing test that already
uses Conn.Raw() to check the type of driverConn.
Fixes issue from #882